search

mbuscemi / elm-lens

Elm code visualizations for maximum productivity in Atom
https://atom.io/packages/elm-lens
MIT License
51 stars 2 forks source link

FontAwesome icons do not load for some users #12

Closed mbuscemi closed 6 years ago

mbuscemi commented 6 years ago

Failed to load resource: net::ERR_FILE_NOT_FOUND fontawesome-webfont.woff2, fontawesome-webfont.woff, fontawesome-webfont.ttf reported by @halohalospecial

mbuscemi commented 6 years ago

Some good progress here. With the help of the Atom console, I've discovered that my fontawesome font files are actually loading from atom://file-icons/fonts/ and not from atom://elm-lens/resources. It appears that registration of that internal Atom URL is not automatic.

mbuscemi commented 6 years ago

The default FontAwesome installation has a version number appended to the font URLs, presumably for caching optimization. This was thwarting Atom's ability to use the URL properly. I stripped those out of the URLs and was then able to load Elm Lens's version of the font files.

Fix coming 0.3.0.

mbuscemi commented 6 years ago

Should be fixed in 0.3. @halohalospecial, please let me know if you're still experiencing this.

halohalospecial commented 6 years ago

Thanks for the fix! It's already working :tada:

mbuscemi commented 6 years ago

Awesome! I'm glad it's working for you.