search

mbylstra / html-to-elm

An online tool for converting HTML to elm-html. Go to
http://mbylstra.github.io/html-to-elm/
395 stars 23 forks source link

Any element gets omitted after a comment containing double quote #1

Closed igrep closed 8 years ago

igrep commented 8 years ago

Input

<div>
  Text
  <span></span> <!-- "" -->
  Text
  <span>aaa</span>
</div>

Actual Output

div []
    [ text "Text  "
    , span []
        []
    ]

Expected Output

div []
    [ text "Text  "
    , span []
        []
    , text "  Text  "
    , span []
        [ text "aaa" ]
    ]
mbylstra commented 8 years ago

Thanks for the detailed bug report. This should be fixed now, although it's brought to my attention a related issue: https://github.com/mbylstra/html-to-elm/issues/4

igrep commented 8 years ago

Looks good. Thanks! :+1: