mc-ascendancy / AscendNations

GNU Affero General Public License v3.0
0 stars 0 forks source link

Add configurable claim blocks #11

Closed VolticFroogo closed 3 years ago

VolticFroogo commented 3 years ago

Add blocks, which upon placement, will claim an area as a home or outpost chunk.

These blocks should be configurable in the generic config file.

VolticFroogo commented 3 years ago

I am making the assumption that the claim block material will be exclusively used for claim blocks (i.e. not used for anything else). Is this an okay assumption, or should I use NBT data to differentiate claim blocks from other regular blocks?

connor7000 commented 3 years ago

The preferred option would be to use NBT data to differentiate claim blocks from other regular blocks ONLY IF we are still able to use the custom textures we've already made for the configurable claim blocks.

VolticFroogo commented 3 years ago

From what I recall, as I will be using custom NBT data with no collisions with regular Minecraft, it should not break custom textures. I will change material differentiation to NBT data in the next update.

VolticFroogo commented 3 years ago

This has been implemented; the blocks are using server-side only metadata, so no collisions should be possible. Items are using 1.16's PersistentDataContainer, yet again, with no collisions possible.

VolticFroogo commented 3 years ago

Currently, the customisable attributes on the block are: its material (not exclusive), name, and lore. Are there any more customisable attributes you would need?

connor7000 commented 3 years ago

Not to my knowledge, no! Unless @NotARobotII has any other ideas.

Frankly, I'm not sure how we denote in a resource pack that a custom textures belongs to a custom NBT thing rather than a standard Minecraft block. But I won't be the one implementing the custom textures anyways, so perhaps there is no need for me to understand that!

Thanks for keeping me in the loop, @VolticFroogo!

VolticFroogo commented 3 years ago

Okay, sounds good!

If any other attributes should be added just reopen this issue.