mc-datapacks / review-tracker

Datapack Review tracker
6 stars 1 forks source link

mcEXP Reborn (re-cert for SoQ) #17

Closed eatYourHashs closed 3 years ago

eatYourHashs commented 3 years ago

Project Page: https://www.planetminecraft.com/data-pack/mcexp-reborn-rpg-progression-rebirthed/ This is a re-submission for the Stamp of Quality. The only changes are additional skills added over the past few updates (which I doubt would cause issues) and the changes made to receive the Stamp of Quality.

EstEarth202 commented 3 years ago

@eatYourHashs

Global Ignoring Tag

There are many mistakes with the global ignoring tag convention but easily fixable:

  1. global.ignore tag in player selector is not allowed & tellraw not required global.ignore & gui

    • [x] mcfunction in mcexp2\functions\levelup folder.
    • [x] mcfunction in mcexp2\functions\prestige folder
    • [x] mcfunction in mcexp2\functions\skill_points folder
    • [x] mcfunction in mcexp2\functions\skillbook\buy folder
    • [x] mcfunction in mcexp2\functions\skillbook folder
    • [x] mcexp2\functions\common_tick `execute as @a[tag=!global.ignore]
    • [x] mcexp2\functions\uninstall `
  2. playsound & particle not required global.ignore & gui
    • [x] mcfunction in mcexp2\functions\skills folder
eatYourHashs commented 3 years ago

I have fixed the issues above; the new release is uploaded to the same PMC link.

EstEarth202 commented 3 years ago

From again review, there were few issues.

And that's all

eatYourHashs commented 3 years ago

I have fixed the above; the new release is once again uploaded to the same PMC link.

EstEarth202 commented 3 years ago