search

mc-datapacks / review-tracker

Datapack Review tracker
6 stars 1 forks source link

Plated Elytra #34

Open mainrs opened 3 years ago

mainrs commented 3 years ago

Project Page: https://github.com/vanilla-friendly-datapacks/plated-elytra

mainrs commented 3 years ago

Sorry, I changed quite a bit yesterday! I hope you didn't start reviewing it already :( I moved to loot tables actually instead of data modify, so it should be easier to review haha @UltroGhast

UltroGhast commented 3 years ago

❌Certified Datapack ❌Stamp of Quality

You need to correct these mistakes:

Global Ignoring Tag Convention

_plated-elytra/data/zerotask/functions/plated_elytra/private/check_crafting.mcfunction_ execute as @e[type=minecraft:item,nbt={Item: {id: "minecraft:elytra"}},nbt=!{Item: {tag: {zerotask: {PlatedElytra: 1b}}}}] at @s if entity @e[type=minecraft:item,nbt={Item: {id: "minecraft:slime_ball"}},distance=..1] if entity @e[type=minecraft:item,nbt={Item: {id: "minecraft:golden_chestplate"}},distance=..1] if block ~ ~-1 ~ minecraft:anvil run function zerotask:plated_elytra/private/craft_golden_plated_elytra and similar ones. Where are all the tag=!global.ignore tags here? You need them for all these selectors, also the ones after if. _plated-elytra/data/zerotask/functions/plated_elytra/private/craft_diamond_platedelytra.mcfunction and others You should add tag=!global.ignore.kill in the kill selectors, also for the kill @s. You need to correct these if you also want the Stamp of Quality:

Common Trait Convention

Just follow it.

Let me know. And nice datapack!