Dragon_heads_plus

[jh1236]

Project Page: https://github.com/jh1236/dragon_heads_plus/tree/1.0.0

[felix91gr]

@jh1236 what does it do? :0

[EstEarth202]

Certified Compatibility ❌

Stamp of Quality ❌

Custom Model ID ☑️

Global ignoring tag ❌

You can remove [tag=!global.ignore] from all @a because This tag does not apply to player-only selectors

Namespace Convention ❌

data\jh1236\functions\dragon_head\breathing_head\arrow\new_arrow.mcfunction -> tag current

data\jh1236\functions\dragon_head\breathing_head\roar\success.mcfunction
data\jh1236\functions\dragon_head\breathing_head\roar\_success\_fn0.mcfunction
  ↳ tag new & motion

Shulker Box Loot Table ❓

I noticed that you use it but ❓. You have ✔️ loot_table yellow_shullker_block ✔️ data modify & loot give air{drop_contents:1b} at 12360 0 0 ❓ But I don't see where the setblock 12360 0 0 yellow_shulker_box is, can you please let me know.

Common Trait Convention 🔆

As a custom item is created, I suggest you can try this along. Which you can customize both with id: '...' traits {...} and in your own namespace, you can find examples from other Certified Datapack. Rough example

{
    "pools": [
        {
            "rolls": 1,
            "entries": [
                {
                    "type": "minecraft:item",
                    "name": "minecraft:dragon_head",
                    "functions": [
                        {
                            "function": "minecraft:set_name",
                            "name": {"text": "Breathing Dragon Head","italic":false,"color":"aqua"}
                        },
                        {
                            "function": "minecraft:set_nbt",
                            "tag": "{ctc: {id: 'breathing_head', from: 'jh1236:dragon_head_plus', traits: {'item': 1b,'armor': 1b, etc: ...}}}"
                        },
                        {
                            "function": "minecraft:set_nbt",
                            "tag": "{jh1236: {...}}"
                        }
                    ]
                }
            ]
        }
    ]
}

Global Durability ☑️

Datapack Advancement ✔️

In fact, the jh1236.json file is not required. "background": "minecraft: textures / block / gray_concrete.png",

Datapack Uninstallation ❌

• [ ] 🔆Did you forget to remove team jh.purple?
• [ ] 🔆Did you forget to remove storage jh1236:dragon_head/gear_change?

Post your work on popular websites. Or you can post only on github.

• [ ] ❌ And don't forget to tell the user how to uninstall it.

  Reloading Message ✔️

Tecnical advice 🔆

Instead of doing this.

execute if entity @s[nbt={ActiveEffects:[{Id:24b,Amplifier:1b}]}] run team join jh.purple @s
execute unless entity @s[nbt={ActiveEffects:[{Id:24b,Amplifier:1b}]}] run team leave @s

You can use it like this.

team join jh.purple @s[nbt={ActiveEffects:[{Id:24b,Amplifier:1b}]}]
team leave @s[nbt=!{ActiveEffects:[{Id:24b,Amplifier:1b}]}]

And you can put them in the file jh1236:dragon_head/breathing_head/as_a Because at @s does not affect team commands.

execute as @a[tag=!global.ignore] at @s
execute as @e[tag=!global.ignore]

I recommend using rewards loot & loot_table for giving items instead of give command.

{
    "rewards": {
      "function": "jh1236:dragon_head/breathing_head/craft",
      "loot": ["jh1236:dragon_head/breathing_head"]
    },
    "criteria": {
      "requirement": {
        "trigger": "minecraft:recipe_unlocked",
        "conditions": {
          "recipe": "jh1236:dragon_head/breathing_head"
        }
      }
    }
  }

Something missing ❓

I guess this datapack is not completely written, is it? I would like to see the finished version. If I could see it, I might be able to give you more guides and I will wait.

Bug report 🐞

-

Note

✔️ = Followed 🔆 = Advised to use ❌ = Doesn't follow ❓ = Doubt / Something missing ☑️ = Not required/Skip

• [ ] = Required -> with ❌ Must do, ✔️ Should do, 🔆 Not force