mc-datapacks / review-tracker

Datapack Review tracker

6 stars 1 forks source link

Disenchanting #70

Closed TheSaltyPug closed 2 years ago

TheSaltyPug commented 3 years ago

Project Page: https://github.com/TheSaltyPug/Disenchanting

EstEarth202 commented 2 years ago

This pack has been Certified + Styte Guideline. But Which is like your other pack, I fixed some points.

But if you ask why I use predicate because I have tried debug profiling several times. I found this method reduces the percentage cost of execute as @ pending at any item drop. opera_sqNdGhDtbf opera_DvU1wOVtOR opera_dXSxcotECs opera_geQnnCIDeT

If you don't have any questions or issues, you can merge pull request and let me know in the comments to close this review. Or, as always, you can reject this as you wish. And I'll close the review for you.

TheSaltyPug commented 2 years ago

Thank you again, Est. Merged changes upstream. You may close with the correct tags.

EstEarth202 commented 2 years ago

Certified Compatibility ✔️

Style Guideline 💕

*Don't forget to tell the user how to uninstall.

You can now use the certified banner for this datapack. The link to your datapack will also be posted on the #certified-datapacks channel. Since you already have both Certified Datapacker and Style Guideline Follower roles, you will not be given any more roles this time.

Final comment: Useful and LMAO Datapack reviewer @EstEarth202. :thumbsup:.

PS. Nice to help and thanks too.