search

mc-imperial / dredd

A mutation testing tool designed to work with large C++ (and C) codebases.
Apache License 2.0
13 stars 3 forks source link

Make --mutation-info-file optional #195

Closed JamesLee-Jones closed 3 months ago

JamesLee-Jones commented 11 months ago

Make --mutation-info-file parameter optional as writing this file can cause issues if the mutation tree is too deep.

JamesLee-Jones commented 11 months ago

Encapsulating whether we want to build the mutation tree in protobufs seemed like the best choice. We can't readily use optional as mutation_info isn't initialised when it is passed to NewMutateFrontendActionFactory.

afd commented 11 months ago

@JamesLee-Jones as part of this PR, can you update the project README so that the instructions no longer use this option (and also remove the comments that explain that the option is mandatory but doesn't matter for purposes of the README examples)?

afd commented 11 months ago

@JamesLee-Jones in my latest push I updated the README so that it does use the generated .json file in the math library example, so it's only for the simple pi example that we'd want to remove all trace of it.

afd commented 4 months ago

I now have bandwidth to look at this again if you want to rebase it and revise it if needed.

JamesLee-Jones commented 4 months ago

I now have bandwidth to look at this again if you want to rebase it and revise it if needed.

I'll revise it today along with the rest of the reviewed PRs.

afd commented 3 months ago

@JamesLee-Jones This needs a rebase, but otherwise should be good to go if you're able to attend to the minor edits.