search

mc-wiki / minecraft-mod-heywiki

A Minecraft mod that allows you to press H (customizable) to open the Minecraft Wiki page of the block/item/entity you're aiming at.
https://minecraft.wiki/MCW:MOD
GNU Lesser General Public License v3.0
65 stars 8 forks source link

Compatibility Issue with Iris Shaders #31

Closed NyteWL closed 6 months ago

NyteWL commented 6 months ago

Steps to reproduce

  1. Install Fabric Loader and API
  2. Install Hey Wiki and its dependencies, Iris Shaders, and Sodium
  3. Start the game
  4. Put a shader pack with lang files in shaderpacks folder and load it
  5. Open the shader pack settings screen and check for the error

Describe the bug

Hey Wiki seems to cause Iris to be unable to read the shader pack's lang file: image0 chinese screen: image2

Expected behavior

Normally, the shader pack settings screen should look like this: image chinese: image1

Mod version

1.4.1

Game version

1.20.4

Operating system

Windows 10

Mod loader

Fabric

Mod loader version

0.15.11

Relevant log/crash report output

https://mclo.gs/v4svZFt

How frustrating is this bug?

No response

Additional information and screenshots

No response

Dianliang233 commented 6 months ago

Relates to this mixin to TranslationStorage (yarn): https://github.com/IrisShaders/Iris/blob/1.20.6/src/main/java/net/irisshaders/iris/mixin/MixinClientLanguage.java

Edit: I think I can pinpoint to the exact line: https://github.com/IrisShaders/Iris/blob/48b6f2b70a6f27739b8c164fe2af0e50cc451cf0/src/main/java/net/irisshaders/iris/mixin/MixinClientLanguage.java#L61. Not sure how to fix