mc12345678 / Stock_By_Attributes_Combined

This combines the Files from SBA 1.5.3 and SBA 1.5.4 to provide a single distribution for updating applicable to ZC 1.5.0, 1.5.1, 1.5.3, 1.5.4, 1.5.5, 1.5.6, 1.5.7 and 1.5.8.
GNU General Public License v2.0
6 stars 8 forks source link

Dynamic Price Updater interoperation #20

Open mc12345678 opened 8 years ago

mc12345678 commented 8 years ago

Have recently used Dynamic Price Updater along with SBA; however, it required some modification in order to not replace the applicable onChange event(s) assigned to the attribute selectors... See DPU sets the applicable event to whatever DPU needs in order to update the price. This is instead of listening to the handler and performing the action that is expected/necessary in addition to whatever other JS is in place. Perhaps if other JS is loaded ahead of DPU it would fire properly, but it doesn't exactly seem that way. Once the applicable element.event was modified to addEventListener the DPU code worked as well as Dynamic Dropdowns... There are or may be other localized modifications necessary as outlined in the DPU forum; however, this characteristic had not been found and was a deterrent to using DPU.

mc12345678 commented 8 years ago

Perhaps more applicable to address in DPU only, but something that still needs to be addressed is detection by DPU that nothing has been selected so that it can return the "starting at..." related text instead of 0.00 or having to some other way fool it into showing a non-zero value. A plugin should work, not have to be worked around.

mc12345678 commented 7 years ago

An additional improvement to DPU is the "separation" of activating DPU response onload from the code itself. This is incorporated in https://github.com/mc12345678/Dynamic_Price_Updater/commit/40722fedbb2ddc9b8d19bae61dde0830c6c5ca0c as part of the mc12345678-sidebox-possibly branch. Using that branch, SBA and DPU are working together even with Dynamic Dropdowns enabled.

mc12345678 commented 7 years ago

Version 3.0.4 of Dynamic Price Updater has been posted, improvements have been made and DPU does work with SBA. Actions taken have removed the 0.00 result when attributes are returned to their base setting. Option to restore to price of starting at: not yet incorporated/developed. Keeping this issue open.