mc1arke / sonarqube-community-branch-plugin

A plugin that allows branch analysis and pull request decoration in the Community version of Sonarqube
GNU Lesser General Public License v3.0
2.22k stars 520 forks source link

Pull request decoration for Azure DevOps Services #102

Closed RobinDink closed 3 years ago

RobinDink commented 4 years ago

Hey @mc1arke,

since you closed the other issue and the 1.3.0-release covers everything but Azure DevOps, I hope you don't mind me opening a new issue for it? I would kindly request pull request decoration for Azure DevOps Services :).

Cheers, Robin

Iloer commented 4 years ago

hi @RobCoPKC Please check the solution from this thread on your server. Plugin version: sonarqube-community-branch-plugin-1.2.1-SNAPSHOT SonarQube version 8.1.0

RobinDink commented 4 years ago

I just installed it and don't see any option to pick Azure DevOps as provider?

image

Iloer commented 4 years ago

Build branch image

on document: https://docs.sonarqube.org/8.1/analysis/pr-decoration/

RobinDink commented 4 years ago

So I have to update to SonarQube 8.1?

Iloer commented 4 years ago

Yes.

pratikibm commented 4 years ago

Build branch image

on document: https://docs.sonarqube.org/8.1/analysis/pr-decoration/

Hi Iloer, I am not able to generate jar file could you please attached here.

pratikibm commented 4 years ago

So I have to update to SonarQube 8.1?

will it work for 8.2 as well?

Iloer commented 4 years ago

Hi @pratikibm, i'm attaching .jar sonarqube-community-branch-plugin-1.2.1-SNAPSHOT.zip

I didn’t check on 8.2, but judging by the discussion history, it should work

pratikibm commented 4 years ago

Hi @pratikibm, i'm attaching .jar sonarqube-community-branch-plugin-1.2.1-SNAPSHOT.zip

I didn’t check on 8.2, but judging by the discussion history, it should work

Thanks @Iloer , I tried it on 8.2, however I can see ALM with Azure DevOps server option but there is no option of Pull request decoration.

Iloer commented 4 years ago

brief instruction 1. image

2. image

cescidistus commented 4 years ago

hello @pratikibm ,

I success to build a version for 8.2. There is a little error on project binding manipulation.

On file GetBindingAction.java, when you call dbClient.projectAlmSettingDao().selectByProject(dbSession,projectDto), projectDto need to be a ProjectDto and not a ComponentDto on version 8.2

Same on file DeleteBindingAction.java

I don't know how to do, if I have to make a pull request on your branch, and I don't know how to make the two version work since I only have the 8.2 version.

To get the project, I add that row ComponentDto project = componentFinder.getByKey(dbSession, projectKey); ProjectDto projectDto = componentFinder.getProjectByKey(dbSession, projectKey);

I attache built version for 8.2 sonarqube-community-branch-plugin-1.2.1-SNAPSHOT.zip

jcuzzi commented 4 years ago

Take a look at #202 . It is working for me using SonarQube 8.2 with Azure DevOps. There are a few required properties that need to be set in the SonarQube Prepare task in the Azure Build Pipeline which are mentioned in the PR.

raschmitt commented 4 years ago

Can anyone confirm if the proposed solution works on 7.9.1?

bbarman4u commented 3 years ago

Can any one please confirm if this Works for the Azure DevOps Services (The Cloud Hosted Version) and not only for the Server version (Self Hosted) since the original issue is stated as open yet I noticed comments on some solutions listed but seems to be only for the server edition ?

jcuzzi commented 3 years ago

Can any one please confirm if this Works for the Azure DevOps Services (The Cloud Hosted Version) and not only for the Server version (Self Hosted) since the original issue is stated as open yet I noticed comments on some solutions listed but seems to be only for the server edition ?

It works for the cloud hosted version too.

bbarman4u commented 3 years ago

Can any one please confirm if this Works for the Azure DevOps Services (The Cloud Hosted Version) and not only for the Server version (Self Hosted) since the original issue is stated as open yet I noticed comments on some solutions listed but seems to be only for the server edition ?

It works for the cloud hosted version too.

@jcuzzi Thanks for the information, I will try this out.

jcuzzi commented 3 years ago

@mc1arke this issue can probably be closed since the feature was released.