search

mc1arke / sonarqube-community-branch-plugin

A plugin that allows branch analysis and pull request decoration in the Community version of Sonarqube
GNU Lesser General Public License v3.0
2.22k stars 521 forks source link

Question about v1.18 and gitLab #865

Closed lche1 closed 8 months ago

lche1 commented 8 months ago

Hi,

We installed on our v10.3 sonarqube instance the last version of branch community plugin (v1.18) and are using a GitLab Community Edition [15.3.3]. We are trying to implement the MR decoration with jenkins without success. On Merge request trigger the pipeline run normally and start the sonarscanner but we get a 'check pipeline status' that never end. The sonarqube configuration for gitLab is ok but the gate quality status report remains disabled. Does anyone have had such a problem or Is there a particular configuration to set ? thanks a lot

Bronek777 commented 8 months ago

i have same problem with jenkins plugin. check sonar.baseUrl parameter in general settings.

mc1arke commented 8 months ago

Without some debug information it's going to be impossible to diagnose this. Does Sonarqube show any logs for attempting decoration (decoration is reported in the Compute Engine logs), does Sonarqube show your MR in the UI, what are the parameters you're setting in the scanner, etc?

lche1 commented 8 months ago

Thanks a lot Michael,

I think we’ve finally fixed the problem on the sonarqube side since we are now able to valid the gitlab configuration in administration>general settings and project settings>general menus. We are now facing another difficulty when we try a pull request analysis.

The sonar parameters are :

-Dsonar.host.url=https://oursonarinstance.fr -Dsonar.login=xxxxxxxxxxxxxxxxx -Dsonar.projectKey=cnav.ptn.demo-qualimetrie-sme:Demo-qualimetrie-sme -Dsonar.projectName="Demo-qualimetrie-sme" -Dsonar.projectVersion=1.0.0-SNAPSHOT -Dsonar.sourceEncoding=UTF-8 -Dsonar.scm.provider=git -Dsonar.scm.disabled=true -Dsonar.java.libraries=/*.jar -Dsonar.java.test.libraries=*/.jar -Dsonar.coverage.exclusions=/config/*.js,/Test,/*.spec.ts,*/.e2e-spec.ts -Dsonar.coverage.jacoco.xmlReportPaths=target/jacoco-ut/jacoco.xml -Dsonar.junit.reportPaths=target/surefire-reports -Dsonar.externalIssuesReportPaths=/home/jenkins/workspace/mo-qualimetrie-sme_feature_dev_1/target/reports/jenkins/trivy-report-sonarqube.json -Dsonar.pullrequest.branch=feature/dev#1 -Dsonar.pullrequest.key=58 -Dsonar.verbose=true

[ce] logs :

2024.02.08 11:28:22 INFO ce[AY2IQuUHS_IgZzvtYmxK][o.s.c.t.s.ComputationStepExecutor] Propagate analysis warnings from scanner report | status=SUCCESS | time=2ms 2024.02.08 11:28:22 INFO ce[AY2IQuUHS_IgZzvtYmxK][o.s.c.t.s.ComputationStepExecutor] Generate analysis UUID | status=SUCCESS | time=0ms 2024.02.08 11:28:22 INFO ce[AY2IQuUHS_IgZzvtYmxK][o.s.c.t.s.ComputationStepExecutor] Load analysis metadata | status=FAILED | time=2ms 2024.02.08 11:28:22 ERROR ce[AY2IQuUHS_IgZzvtYmxK][o.s.c.t.s.ComputationStepExecutor] Execution of listener failed java.lang.IllegalStateException: Branch has not been set at com.google.common.base.Preconditions.checkState(Preconditions.java:512) at org.sonar.ce.task.projectanalysis.analysis.AnalysisMetadataHolderImpl.getBranch(AnalysisMetadataHolderImpl.java:136) at org.sonar.ce.task.projectanalysis.api.posttask.PostProjectAnalysisTasksExecutor.createBranch(PostProjectAnalysisTasksExecutor.java:194) at org.sonar.ce.task.projectanalysis.api.posttask.PostProjectAnalysisTasksExecutor.createProjectAnalysis(PostProjectAnalysisTasksExecutor.java:157) at org.sonar.ce.task.projectanalysis.api.posttask.PostProjectAnalysisTasksExecutor.finished(PostProjectAnalysisTasksExecutor.java:90) at org.sonar.ce.task.step.ComputationStepExecutor.executeListener(ComputationStepExecutor.java:89) at org.sonar.ce.task.step.ComputationStepExecutor.execute(ComputationStepExecutor.java:61) at org.sonar.ce.task.projectanalysis.taskprocessor.ReportTaskProcessor.process(ReportTaskProcessor.java:75) at org.sonar.ce.taskprocessor.CeWorkerImpl$ExecuteTask.executeTask(CeWorkerImpl.java:212) at org.sonar.ce.taskprocessor.CeWorkerImpl$ExecuteTask.run(CeWorkerImpl.java:194) at org.sonar.ce.taskprocessor.CeWorkerImpl.findAndProcessTask(CeWorkerImpl.java:160) at org.sonar.ce.taskprocessor.CeWorkerImpl$TrackRunningState.get(CeWorkerImpl.java:135) at org.sonar.ce.taskprocessor.CeWorkerImpl.call(CeWorkerImpl.java:87) at org.sonar.ce.taskprocessor.CeWorkerImpl.call(CeWorkerImpl.java:53) at com.google.common.util.concurrent.TrustedListenableFutureTask$TrustedFutureInterruptibleTask.runInterruptibly(TrustedListenableFutureTask.java:131) at com.google.common.util.concurrent.InterruptibleTask.run(InterruptibleTask.java:75) at com.google.common.util.concurrent.TrustedListenableFutureTask.run(TrustedListenableFutureTask.java:82) at java.base/java.util.concurrent.Executors$RunnableAdapter.call(Unknown Source) at java.base/java.util.concurrent.FutureTask.run(Unknown Source) at java.base/java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(Unknown Source) at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(Unknown Source) at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(Unknown Source) at java.base/java.lang.Thread.run(Unknown Source) 2024.02.08 11:28:22 ERROR ce[AY2IQuUHS_IgZzvtYmxK][o.s.c.t.CeWorkerImpl] Failed to execute task AY2IQuUHS_IgZzvtYmxK java.lang.IllegalStateException: Branches and Pull Requests are not supported in Community Edition at com.google.common.base.Preconditions.checkState(Preconditions.java:512) at org.sonar.ce.task.projectanalysis.analysis.AnalysisMetadataHolderImpl.setBranch(AnalysisMetadataHolderImpl.java:127) at com.github.mc1arke.sonarqube.plugin.ce.CommunityBranchLoaderDelegate.load(CommunityBranchLoaderDelegate.java:52) at org.sonar.ce.task.projectanalysis.component.BranchLoader.load(BranchLoader.java:50) at org.sonar.ce.task.projectanalysis.step.LoadReportAnalysisMetadataHolderStep.execute(LoadReportAnalysisMetadataHolderStep.java:74) at org.sonar.ce.task.step.ComputationStepExecutor.executeStep(ComputationStepExecutor.java:79) at org.sonar.ce.task.step.ComputationStepExecutor.executeSteps(ComputationStepExecutor.java:70) at org.sonar.ce.task.step.ComputationStepExecutor.execute(ComputationStepExecutor.java:57) at org.sonar.ce.task.projectanalysis.taskprocessor.ReportTaskProcessor.process(ReportTaskProcessor.java:75) at org.sonar.ce.taskprocessor.CeWorkerImpl$ExecuteTask.executeTask(CeWorkerImpl.java:212) at org.sonar.ce.taskprocessor.CeWorkerImpl$ExecuteTask.run(CeWorkerImpl.java:194) at org.sonar.ce.taskprocessor.CeWorkerImpl.findAndProcessTask(CeWorkerImpl.java:160) at org.sonar.ce.taskprocessor.CeWorkerImpl$TrackRunningState.get(CeWorkerImpl.java:135) at org.sonar.ce.taskprocessor.CeWorkerImpl.call(CeWorkerImpl.java:87) at org.sonar.ce.taskprocessor.CeWorkerImpl.call(CeWorkerImpl.java:53) at com.google.common.util.concurrent.TrustedListenableFutureTask$TrustedFutureInterruptibleTask.runInterruptibly(TrustedListenableFutureTask.java:131) at com.google.common.util.concurrent.InterruptibleTask.run(InterruptibleTask.java:75) at com.google.common.util.concurrent.TrustedListenableFutureTask.run(TrustedListenableFutureTask.java:82) at java.base/java.util.concurrent.Executors$RunnableAdapter.call(Unknown Source) at java.base/java.util.concurrent.FutureTask.run(Unknown Source) at java.base/java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(Unknown Source) at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(Unknown Source) at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(Unknown Source) at java.base/java.lang.Thread.run(Unknown Source)

Without the options -Dsonar.pullrequest.branch and -Dsonar.pullrequest.key, no error but the gitLab MR is still not notified.

Thank you for help.

De : Michael Clarke @.> Envoyé : mardi 6 février 2024 07:06 À : mc1arke/sonarqube-community-branch-plugin @.> Cc : CHERREY Laurent @.>; Author @.> Objet : Re: [mc1arke/sonarqube-community-branch-plugin] Question about v1.18 and gitLab (Issue #865)

Without some debug information it's going to be impossible to diagnose this. Does Sonarqube show any logs for attempting decoration (decoration is reported in the Compute Engine logs), does Sonarqube show your MR in the UI, what are the parameters you're setting in the scanner, etc?

— Reply to this email directly, view it on GitHubhttps://github.com/mc1arke/sonarqube-community-branch-plugin/issues/865#issuecomment-1928845315, or unsubscribehttps://github.com/notifications/unsubscribe-auth/BFVTZUBMUXD3Q4GUS7H57C3YSHB5JAVCNFSM6AAAAABCO5DVXOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMRYHA2DKMZRGU. You are receiving this because you authored the thread.Message ID: @.**@.>>

***** Ce message électronique, les éventuels fichiers joints et les informations qu'il contient, peuvent être couverts par le secret professionnel et sont exclusivement adressés à son destinataire. Si vous le recevez par erreur, merci d'en informer l'expéditeur et de le détruire. A ce titre, toute diffusion non autorisée de ce message, même partielle, sous quelque forme que ce soit, est interdite et punie par la loi. En aucun cas, le contenu de ce message ne peut valoir offre ou acceptation ou engagement de la part de la CNAV. Les opinions contenues dans ce message sont personnelles à l'émetteur. Il est de la responsabilité du destinataire de s'assurer que le message et ses éventuelles pièces jointes ne contiennent pas de virus informatique.

lche1 commented 8 months ago

Hi Michael,

Sorry for the question in my last mail, it was because of a mistake in the – javaAdditionalOpts in ou config file.. All is working fine now !!!

Thank a lot for your work and your support.

De : CHERREY Laurent Envoyé : jeudi 8 février 2024 15:54 À : 'mc1arke/sonarqube-community-branch-plugin' @.***> Objet : RE: [mc1arke/sonarqube-community-branch-plugin] Question about v1.18 and gitLab (Issue #865)

Thanks a lot Michael,

I think we’ve finally fixed the problem on the sonarqube side since we are now able to valid the gitlab configuration in administration>general settings and project settings>general menus. We are now facing another difficulty when we try a pull request analysis.

The sonar parameters are :

-Dsonar.host.url=https://oursonarinstance.fr -Dsonar.login=xxxxxxxxxxxxxxxxx -Dsonar.projectKey=cnav.ptn.demo-qualimetrie-sme:Demo-qualimetrie-sme -Dsonar.projectName="Demo-qualimetrie-sme" -Dsonar.projectVersion=1.0.0-SNAPSHOT -Dsonar.sourceEncoding=UTF-8 -Dsonar.scm.provider=git -Dsonar.scm.disabled=true -Dsonar.java.libraries=/*.jar -Dsonar.java.test.libraries=*/.jar -Dsonar.coverage.exclusions=/config/*.js,/Test,/*.spec.ts,*/.e2e-spec.ts -Dsonar.coverage.jacoco.xmlReportPaths=target/jacoco-ut/jacoco.xml -Dsonar.junit.reportPaths=target/surefire-reports -Dsonar.externalIssuesReportPaths=/home/jenkins/workspace/mo-qualimetrie-sme_feature_dev_1/target/reports/jenkins/trivy-report-sonarqube.json -Dsonar.pullrequest.branch=feature/dev#1 -Dsonar.pullrequest.key=58 -Dsonar.verbose=true

[ce] logs :

2024.02.08 11:28:22 INFO ce[AY2IQuUHS_IgZzvtYmxK][o.s.c.t.s.ComputationStepExecutor] Propagate analysis warnings from scanner report | status=SUCCESS | time=2ms 2024.02.08 11:28:22 INFO ce[AY2IQuUHS_IgZzvtYmxK][o.s.c.t.s.ComputationStepExecutor] Generate analysis UUID | status=SUCCESS | time=0ms 2024.02.08 11:28:22 INFO ce[AY2IQuUHS_IgZzvtYmxK][o.s.c.t.s.ComputationStepExecutor] Load analysis metadata | status=FAILED | time=2ms 2024.02.08 11:28:22 ERROR ce[AY2IQuUHS_IgZzvtYmxK][o.s.c.t.s.ComputationStepExecutor] Execution of listener failed java.lang.IllegalStateException: Branch has not been set at com.google.common.base.Preconditions.checkState(Preconditions.java:512) at org.sonar.ce.task.projectanalysis.analysis.AnalysisMetadataHolderImpl.getBranch(AnalysisMetadataHolderImpl.java:136) at org.sonar.ce.task.projectanalysis.api.posttask.PostProjectAnalysisTasksExecutor.createBranch(PostProjectAnalysisTasksExecutor.java:194) at org.sonar.ce.task.projectanalysis.api.posttask.PostProjectAnalysisTasksExecutor.createProjectAnalysis(PostProjectAnalysisTasksExecutor.java:157) at org.sonar.ce.task.projectanalysis.api.posttask.PostProjectAnalysisTasksExecutor.finished(PostProjectAnalysisTasksExecutor.java:90) at org.sonar.ce.task.step.ComputationStepExecutor.executeListener(ComputationStepExecutor.java:89) at org.sonar.ce.task.step.ComputationStepExecutor.execute(ComputationStepExecutor.java:61) at org.sonar.ce.task.projectanalysis.taskprocessor.ReportTaskProcessor.process(ReportTaskProcessor.java:75) at org.sonar.ce.taskprocessor.CeWorkerImpl$ExecuteTask.executeTask(CeWorkerImpl.java:212) at org.sonar.ce.taskprocessor.CeWorkerImpl$ExecuteTask.run(CeWorkerImpl.java:194) at org.sonar.ce.taskprocessor.CeWorkerImpl.findAndProcessTask(CeWorkerImpl.java:160) at org.sonar.ce.taskprocessor.CeWorkerImpl$TrackRunningState.get(CeWorkerImpl.java:135) at org.sonar.ce.taskprocessor.CeWorkerImpl.call(CeWorkerImpl.java:87) at org.sonar.ce.taskprocessor.CeWorkerImpl.call(CeWorkerImpl.java:53) at com.google.common.util.concurrent.TrustedListenableFutureTask$TrustedFutureInterruptibleTask.runInterruptibly(TrustedListenableFutureTask.java:131) at com.google.common.util.concurrent.InterruptibleTask.run(InterruptibleTask.java:75) at com.google.common.util.concurrent.TrustedListenableFutureTask.run(TrustedListenableFutureTask.java:82) at java.base/java.util.concurrent.Executors$RunnableAdapter.call(Unknown Source) at java.base/java.util.concurrent.FutureTask.run(Unknown Source) at java.base/java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(Unknown Source) at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(Unknown Source) at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(Unknown Source) at java.base/java.lang.Thread.run(Unknown Source) 2024.02.08 11:28:22 ERROR ce[AY2IQuUHS_IgZzvtYmxK][o.s.c.t.CeWorkerImpl] Failed to execute task AY2IQuUHS_IgZzvtYmxK java.lang.IllegalStateException: Branches and Pull Requests are not supported in Community Edition at com.google.common.base.Preconditions.checkState(Preconditions.java:512) at org.sonar.ce.task.projectanalysis.analysis.AnalysisMetadataHolderImpl.setBranch(AnalysisMetadataHolderImpl.java:127) at com.github.mc1arke.sonarqube.plugin.ce.CommunityBranchLoaderDelegate.load(CommunityBranchLoaderDelegate.java:52) at org.sonar.ce.task.projectanalysis.component.BranchLoader.load(BranchLoader.java:50) at org.sonar.ce.task.projectanalysis.step.LoadReportAnalysisMetadataHolderStep.execute(LoadReportAnalysisMetadataHolderStep.java:74) at org.sonar.ce.task.step.ComputationStepExecutor.executeStep(ComputationStepExecutor.java:79) at org.sonar.ce.task.step.ComputationStepExecutor.executeSteps(ComputationStepExecutor.java:70) at org.sonar.ce.task.step.ComputationStepExecutor.execute(ComputationStepExecutor.java:57) at org.sonar.ce.task.projectanalysis.taskprocessor.ReportTaskProcessor.process(ReportTaskProcessor.java:75) at org.sonar.ce.taskprocessor.CeWorkerImpl$ExecuteTask.executeTask(CeWorkerImpl.java:212) at org.sonar.ce.taskprocessor.CeWorkerImpl$ExecuteTask.run(CeWorkerImpl.java:194) at org.sonar.ce.taskprocessor.CeWorkerImpl.findAndProcessTask(CeWorkerImpl.java:160) at org.sonar.ce.taskprocessor.CeWorkerImpl$TrackRunningState.get(CeWorkerImpl.java:135) at org.sonar.ce.taskprocessor.CeWorkerImpl.call(CeWorkerImpl.java:87) at org.sonar.ce.taskprocessor.CeWorkerImpl.call(CeWorkerImpl.java:53) at com.google.common.util.concurrent.TrustedListenableFutureTask$TrustedFutureInterruptibleTask.runInterruptibly(TrustedListenableFutureTask.java:131) at com.google.common.util.concurrent.InterruptibleTask.run(InterruptibleTask.java:75) at com.google.common.util.concurrent.TrustedListenableFutureTask.run(TrustedListenableFutureTask.java:82) at java.base/java.util.concurrent.Executors$RunnableAdapter.call(Unknown Source) at java.base/java.util.concurrent.FutureTask.run(Unknown Source) at java.base/java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(Unknown Source) at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(Unknown Source) at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(Unknown Source) at java.base/java.lang.Thread.run(Unknown Source)

Without the options -Dsonar.pullrequest.branch and -Dsonar.pullrequest.key, no error but the gitLab MR is still not notified.

Thank you for help.

De : Michael Clarke @.**@.>> Envoyé : mardi 6 février 2024 07:06 À : mc1arke/sonarqube-community-branch-plugin @.**@.>> Cc : CHERREY Laurent @.**@.>>; Author @.**@.>> Objet : Re: [mc1arke/sonarqube-community-branch-plugin] Question about v1.18 and gitLab (Issue #865)

Without some debug information it's going to be impossible to diagnose this. Does Sonarqube show any logs for attempting decoration (decoration is reported in the Compute Engine logs), does Sonarqube show your MR in the UI, what are the parameters you're setting in the scanner, etc?

— Reply to this email directly, view it on GitHubhttps://github.com/mc1arke/sonarqube-community-branch-plugin/issues/865#issuecomment-1928845315, or unsubscribehttps://github.com/notifications/unsubscribe-auth/BFVTZUBMUXD3Q4GUS7H57C3YSHB5JAVCNFSM6AAAAABCO5DVXOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMRYHA2DKMZRGU. You are receiving this because you authored the thread.Message ID: @.**@.>>

***** Ce message électronique, les éventuels fichiers joints et les informations qu'il contient, peuvent être couverts par le secret professionnel et sont exclusivement adressés à son destinataire. Si vous le recevez par erreur, merci d'en informer l'expéditeur et de le détruire. A ce titre, toute diffusion non autorisée de ce message, même partielle, sous quelque forme que ce soit, est interdite et punie par la loi. En aucun cas, le contenu de ce message ne peut valoir offre ou acceptation ou engagement de la part de la CNAV. Les opinions contenues dans ce message sont personnelles à l'émetteur. Il est de la responsabilité du destinataire de s'assurer que le message et ses éventuelles pièces jointes ne contiennent pas de virus informatique.