Closed OneCyrus closed 3 months ago
mc1arke
commented
7 months ago I've not properly tested the plugin against 10.5 yet. The release is binary compatible with 10.4 for the classes we depend on so the plugin compiles and starts with the UI showing branches, but I've not tried running any scans yet.
OneCyrus
commented
7 months ago just saw this on the upgrade notes for 10.5. not sure if this has any impact on this plugin.
https://docs.sonarsource.com/sonarqube/latest/setup-and-upgrade/release-upgrade-notes/
xC0dex
commented
7 months ago Hey, I've tested SonarQube Community Edition 10.5 with the plugin 1.19. The MR-Analysis works fine. However, I spotted that instead of an SVG, a PNG is used in the MR decoration. The browser cannot load the image due to some new headers in the response of images:
To be honest, I'm not sure if this header was added by SonarQube ~or by our host~. Maybe someone else can verify this change.
OneCyrus
commented
7 months ago we upgraded now and so far everything seems to work as expected. we are using GitHub only.
dkeitzel
commented
7 months ago I ran into an incompatiblity when setting up a the 'DevOps Platform Integration' on a newly created SonarQube project. This is the exception:
java.lang.NoSuchMethodError: 'void org.sonar.db.alm.setting.ProjectAlmSettingDao.insertOrUpdate(org.sonar.db.DbSession, org.sonar.db.alm.setting.ProjectAlmSettingDto, java.lang.String, java.lang.String, java.lang.String)'I guess the cause is commit 99bf48a for ProjectAlmSettingDao#insertOrUpdate which is called in https://github.com/mc1arke/sonarqube-community-branch-plugin/blob/33536122338e505088080c4795bb8b4be37588ba/src/main/java/com/github/mc1arke/sonarqube/plugin/server/pullrequest/ws/binding/action/SetBindingAction.java#L58
However, I just recompiled the 1.19.0 tag of this plugin but referenced sonarqube 10.5 in https://github.com/mc1arke/sonarqube-community-branch-plugin/blob/33536122338e505088080c4795bb8b4be37588ba/build.gradle#L43
This solved the issue.
gjabouley-invn
commented
6 months ago we upgraded now and so far everything seems to work as expected. we are using GitHub only.
Hi, are you using 'DevOps Platform Integration' feature ?
Need to upgrade to 10.5 to fix https://sonarsource.atlassian.net/browse/SONAR-21600, but as we are heavily relying on this feature (which is not easy to test on a sandbox platform) i would prefer to confirm this point...
Change #904 made sense, but got rejected so situation is not clear
RoboNET
commented
6 months ago To be honest, I'm not sure if this header was added by SonarQube or by our host. Maybe someone else can verify this change.
I tested this on our installation. Same behavior. Looks like SonarQube started adding this headers.
gjabouley-invn
commented
6 months ago To be honest, I'm not sure if this header was added by SonarQube or by our host. Maybe someone else can verify this change.
I tested this on our installation. Same behavior. Looks like SonarQube started adding this headers.
Might be related to https://sonarsource.atlassian.net/browse/SONAR-21780
Can probably we solved using https://github.com/mc1arke/sonarqube-community-branch-plugin?tab=readme-ov-file#serving-images-for-pr-decoration
xC0dex
commented
6 months ago Might be related to https://sonarsource.atlassian.net/browse/SONAR-21780
Good spot. Maybe they will address this issue with https://sonarsource.atlassian.net/browse/SONAR-22149
dm-bil
commented
6 months ago Hi
Everything works fine for me except PR merge prevention
When my PR does not pass Quality Gate merge is being blocked, but when the check is passed the second check (which blocks merge or allows to merge) is in "Expected — Waiting for status to be reported" status for ages, tried to wait up to 30 mins but it was still running
chriscarpenter12
commented
6 months ago I ran into an incompatiblity when setting up a the 'DevOps Platform Integration' on a newly created SonarQube project. This is the exception:
java.lang.NoSuchMethodError: 'void org.sonar.db.alm.setting.ProjectAlmSettingDao.insertOrUpdate(org.sonar.db.DbSession, org.sonar.db.alm.setting.ProjectAlmSettingDto, java.lang.String, java.lang.String, java.lang.String)'
Had the same error with 10.5 helm install with the 1.19.0 plugin. It wasn't until I added a new project that I realized it couldn't be linked in the DevOps Platform Integration settings.
RoboNET
commented
5 months ago I ran into an incompatiblity when setting up a the 'DevOps Platform Integration' on a newly created SonarQube project. This is the exception:
java.lang.NoSuchMethodError: 'void org.sonar.db.alm.setting.ProjectAlmSettingDao.insertOrUpdate(org.sonar.db.DbSession, org.sonar.db.alm.setting.ProjectAlmSettingDto, java.lang.String, java.lang.String, java.lang.String)'Had the same error with 10.5 helm install with the 1.19.0 plugin. It wasn't until I added a new project that I realized it couldn't be linked in the DevOps Platform Integration settings.
Same error. Falling when trying update settings on existing project. Sonar 10.5.1, plugin 1.19.0
gjabouley-invn
commented
5 months ago For people having similar issue, can you test version available in https://github.com/mc1arke/sonarqube-community-branch-plugin/pull/904#issuecomment-2129128434 and provide feedback?
azun-c
commented
4 months ago I'm having the issue: java.lang.NoClassDefFoundError with SonarQube v10.5.1 and community-branch-plugin v1.19.0
Exception in thread "Thread-0" java.lang.NoClassDefFoundError: ch/qos/logback/classic/spi/ThrowableProxy
at ch.qos.logback.classic.spi.LoggingEvent.<init>(LoggingEvent.java:145)
at ch.qos.logback.classic.Logger.buildLoggingEventAndAppend(Logger.java:424)
at ch.qos.logback.classic.Logger.filterAndLog_0_Or3Plus(Logger.java:386)
at ch.qos.logback.classic.Logger.error(Logger.java:543)
at org.eclipse.jgit.internal.util.ShutdownHook.cleanup(ShutdownHook.java:87)
at java.base/java.lang.Thread.run(Thread.java:840)
Caused by: java.lang.ClassNotFoundException: ch.qos.logback.classic.spi.ThrowableProxy
at java.base/java.net.URLClassLoader.findClass(URLClassLoader.java:445)
at org.sonarsource.scanner.api.internal.IsolatedClassloader.loadClass(IsolatedClassloader.java:82)
at java.base/java.lang.ClassLoader.loadClass(ClassLoader.java:525)and
04:02:17.935 ERROR: Cleanup during JVM shutdown failed
java.util.concurrent.ExecutionException: java.lang.NoClassDefFoundError
at java.base/java.util.concurrent.ForkJoinTask.reportExecutionException(ForkJoinTask.java:605)
at java.base/java.util.concurrent.ForkJoinTask.get(ForkJoinTask.java:1004)
at org.eclipse.jgit.internal.util.ShutdownHook.cleanup(ShutdownHook.java:82)
at java.base/java.lang.Thread.run(Thread.java:840)
Caused by: java.lang.NoClassDefFoundError: null
at java.base/jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method)
at java.base/jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:77)
at java.base/jdk.internal.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
at java.base/java.lang.reflect.Constructor.newInstanceWithCaller(Constructor.java:499)
at java.base/java.lang.reflect.Constructor.newInstance(Constructor.java:480)
at java.base/java.util.concurrent.ForkJoinTask.getThrowableException(ForkJoinTask.java:564)
at java.base/java.util.concurrent.ForkJoinTask.reportExecutionException(ForkJoinTask.java:604)
... 3 common frames omitted
Caused by: java.lang.NoClassDefFoundError: org/eclipse/jgit/internal/JGitText
at org.eclipse.jgit.internal.util.ShutdownHook.notify(ShutdownHook.java:97)
at java.base/java.util.stream.ForEachOps$ForEachOp$OfRef.accept(ForEachOps.java:183)
at java.base/java.util.concurrent.ConcurrentHashMap$KeySpliterator.forEachRemaining(ConcurrentHashMap.java:3573)
at java.base/java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:509)
at java.base/java.util.stream.ForEachOps$ForEachTask.compute(ForEachOps.java:290)
at java.base/java.util.concurrent.CountedCompleter.exec(CountedCompleter.java:754)
at java.base/java.util.concurrent.ForkJoinTask.doExec(ForkJoinTask.java:373)
at java.base/java.util.concurrent.ForkJoinTask.invoke(ForkJoinTask.java:686)
at java.base/java.util.stream.ForEachOps$ForEachOp.evaluateParallel(ForEachOps.java:159)
at java.base/java.util.stream.ForEachOps$ForEachOp$OfRef.evaluateParallel(ForEachOps.java:173)
at java.base/java.util.stream.AbstractPipeline.evaluate(AbstractPipeline.java:233)
at java.base/java.util.stream.ReferencePipeline.forEach(ReferencePipeline.java:596)
at java.base/java.util.stream.ReferencePipeline$Head.forEach(ReferencePipeline.java:765)
at org.eclipse.jgit.internal.util.ShutdownHook.doCleanup(ShutdownHook.java:93)
at org.eclipse.jgit.internal.util.ShutdownHook.lambda$1(ShutdownHook.java:80)
at java.base/java.util.concurrent.ForkJoinTask$AdaptedCallable.exec(ForkJoinTask.java:1428)
at java.base/java.util.concurrent.ForkJoinTask.doExec(ForkJoinTask.java:373)
at java.base/java.util.concurrent.ForkJoinPool$WorkQueue.topLevelExec(ForkJoinPool.java:1182)
at java.base/java.util.concurrent.ForkJoinPool.scan(ForkJoinPool.java:1655)
at java.base/java.util.concurrent.ForkJoinPool.runWorker(ForkJoinPool.java:1622)
at java.base/java.util.concurrent.ForkJoinWorkerThread.run(ForkJoinWorkerThread.java:165)
Caused by: java.lang.ClassNotFoundException: org.eclipse.jgit.internal.JGitText
at java.base/java.net.URLClassLoader.findClass(URLClassLoader.java:445)
at org.sonarsource.scanner.api.internal.IsolatedClassloader.loadClass(IsolatedClassloader.java:82)
at java.base/java.lang.ClassLoader.loadClass(ClassLoader.java:525)
... 21 common frames omittedPer my investigations, i think the problem is related to: jgit
PS: Although there have been some errors, but still the PR decoration still works fine.
gjabouley-invn
commented
4 months ago Hello @azun-c
logback error is a cosmetic bug in SonarQube 10.5, fixed in 10.6: https://community.sonarsource.com/t/error-after-analysis-noclassdeffounderror-ch-qos-logback-classic-spi-throwableproxy/113733/92
Analysis should complete anyway
For the JGitText error, someone mentioned in it above discussion, but not sure about the status. Seems you might need to update your Sonar Scanner...
azun-c
commented
4 months ago Thanks @gjabouley-invn I didn't know these were issues of SonarQube. I'll update as you suggested.
now that 10.5 is out.
https://www.sonarsource.com/products/sonarqube/whats-new/sonarqube-10-5/
anyone tried the current plugin with 10.5 yet? did it work?