mc1arke / sonarqube-community-branch-plugin

A plugin that allows branch analysis and pull request decoration in the Community version of Sonarqube
GNU Lesser General Public License v3.0
2.26k stars 526 forks source link

#959: Ensure multi-line string are enclosed in blockquotes #961

Closed mc1arke closed 2 months ago

mc1arke commented 2 months ago

The Github Cloud API now returns an error about the input message being malformed, seemingly due to a change in how new lines in messages are being handled. As the use of blockquotes around multi-line messages appears to continue to work, the analysis messages are being wrapped in blockquotes rather than double-quotes where they contain newline characters. This requires an interim measure of cloning the InputObject class from the nodes library to alter the String comparison and wrapping since the library is no longer maintained.

sonarcloud[bot] commented 2 months ago

Quality Gate Failed Quality Gate failed

Failed conditions
57.5% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

jrx-sjg commented 2 months ago

any chance of get this working soon?

pedrocarrico commented 2 months ago

@mc1arke I can confirm that this fixes the issue, thank you very much for your fast response.

zisuu commented 2 months ago

I can confirm that the snapshot version works here and solved the pull request decoration issue

qalinn commented 2 months ago

@mc1arke Any idea when will be merged this PR? Just an estimation if you can provide. Thank you!

htian-tg commented 2 months ago

@mc1arke Really appreciate if this PR can be merged and the new release 1.22.0 or hotfix 1.21.x can be released soon. Thanks.