search

mc2-center / csbc-pson-dcc

Data coordination resources for the NCI CSBC and PS-ON consortia
1 stars 4 forks source link

New grants have instituin name mismatches #87

Closed andrewelamb closed 4 years ago

andrewelamb commented 4 years ago

Some of the new grants have institution info that is a bit off from the value sin the intsitution table.

The prod values are thos in the current merged grant table, and the test values are those in the institution table:

$value_diffs$institutionAlias
# A tibble: 3 x 3
  grantId     prod                                         test                              
  <chr>       <chr>                                        <chr>                             
1 syn9775595  "[\"Houston Methodist\", \"Weill Cornell\"]" "[\"Houston Methodist\", \"WCM\"]"
2 syn22115225 "[\"Gtech\", \"Emory\"]"                     "[\"GTech\", \"Emory\"]"          
3 syn22117060 "[\"Umichigan\", \"UCMC\"]"                  "[\"UMichigan\", \"UCMC\"]"

The diffs above are mostly capitalization issues

> grant_differences$value_diffs$grantInstitution$prod
[1] "[\"Massachusetts General Hospital\", \"Harvard Medical School\"]"                                                               
[2] "[\"University of California, San Francisco\", \"California Institute of Technology\", \"City Of Hope National Medical Center\"]"
[3] "[\"University of Florida \", \"Columbia University\", \"University of Massachusetts Medical School\"]"                          
[4] "[\"Univserity of Illinois at Chicago\"]"                                                                                        
[5] "[\"Yale University\", \"Salk Institute of Biological Studies\"]"    

> grant_differences$value_diffs$grantInstitution$test
[1] "[\"Massachusetts General Hospital\", \"HarvardMedicalSchool\"]"                                                                 
[2] "[\"University of California, San Francisco\", \"City Of Hope National Medical Center\", \"California Institute of Technology\"]"
[3] "[\"University of Florida\", \"Columbia University\", \"University of Massachusetts Medical School\"]"                           
[4] "[\"University of Illinois at Chicago\"]"                                                                                        
[5] "[\"Yale University\", \"Salk Institute for Biological Studies\"]"

There are some typos, and one that just has a different order. I can go and fix these if that's ok.

vpchung commented 4 years ago

Regarding the first issue with the institutionAlias differences -- I had gotten "GTech" and "UMichigan" from the displayName values of this table. For future grants, should I continue with "Gtech" and "Umichigan" instead?

As for the typos.... sorry about that :sweat_smile: If it's easy to fix, I would greatly appreciate the help. Thank you!

vpchung commented 4 years ago

Ah, disregard my first comment! I had gotten the two tables backward -- thought test was from me.