search

mc2-center / nf-histoqc

A Nextflow wrapper for HistoQC
MIT License
0 stars 1 forks source link

Simplfy histoqc module #18

Closed adamjtaylor closed 8 months ago

adamjtaylor commented 8 months ago

Thanks to feedback from Brad MacDonald in code review, this PR simplifies the histoqc.nf module file by transforming params$config to a new variable $config_var which is “-c $params.config” when $params.config is not default and an empty string when default. This then allows for a single rather than conditional script section.

I also fix the name of the HistoQC output directory within the process

adamjtaylor commented 8 months ago

I am an idiot! You can just specify -c default and therefore just pass the ${params.config} in directly.