Add MbedTLS support - Githubissues

mc2-project / federated-xgboost

Federated gradient boosted decision tree learning

68 stars 20 forks source link

Closed podcastinator closed 4 years ago

podcastinator commented 4 years ago

Adds TLS connections between each node and aggregator. Fixes #3.

chester-leung commented 4 years ago

Looks great! Couple things:

Can you add the libmbedtls-dev package as a dependency in the README? Maybe to Step 2 in the "Installation" section as an additional package for apt to install.
Can you merge the mbedtls branch in our rabit fork to master? I'm thinking that our dmlc-core and rabit forks can be dedicated for federated-xgboost, and it'd be good to make the head of the master branches of those two forks the commits the respective submodules in federated-xgboost point to.

podcastinator commented 4 years ago

Done!

chester-leung commented 4 years ago

Thanks!