search

mc2-project / mc2

A Platform for Secure Analytics and Machine Learning
Apache License 2.0
297 stars 43 forks source link

Replace print statement with logger #187

Open jochasinga opened 3 years ago

jochasinga commented 3 years ago

As per #179

chester-leung commented 3 years ago

@jochasinga you can auto-fix the linting errors before committing by following step 3 here. We use pre-commit to format everything.

I'm not sure we should be changing the print() statements in the setup.py file to log messages -- this file is special as running the file will install the Python package. We use print() statements to more clearly notify the user of any installation / environment variable modifications. Using a logger may obscure the messaging. @ryanleh what do you think?

ryanleh commented 3 years ago

Ya, if we eventually want to push the package to PyPi then I think we'll need to stick with print statements? Not sure how the logger would interact with pip.

Per the linked issue, I think switching to using a logger for the tests making sense, but not the install script.