mc2-project / mc2

A Platform for Secure Analytics and Machine Learning
Apache License 2.0
297 stars 43 forks source link

[Hotfix] Always attest compute service regardless of what has been cached #196

Closed octaviansima closed 2 years ago

octaviansima commented 2 years ago

This PR removes the check for cached attestation evidence in place of always retrieving it from the CS. The CS updates its own state when its asked for attestation evidence, and not initiating this call resulted in "Attestation not complete" error messages.

chester-leung commented 2 years ago

Can you please summarize the changes you made in the description?

Also, @ryanleh running mc2 stop should remove all cached attestation reports right? So I guess your change @octaviansima will have the client attest every time a mc2 run call is made?

octaviansima commented 2 years ago

I think the problem actually came from manually running/stopping the attestation service without using mc2 start or mc2 stop. When I would restart without stopping, then the GetRemoteEvidence would never be called and the CS would not begin attestation.

chester-leung commented 2 years ago

LGTM! Thanks!