Closed chester-leung closed 4 years ago
Merging #121 into master will decrease coverage by
0.35%
. The diff coverage is0.00%
.
@@ Coverage Diff @@
## master #121 +/- ##
==========================================
- Coverage 36.39% 36.04% -0.36%
==========================================
Files 16 16
Lines 2871 2910 +39
==========================================
+ Hits 1045 1049 +4
- Misses 1826 1861 +35
Impacted Files | Coverage Δ | |
---|---|---|
python-package/securexgboost/remote_server.py | 9.45% <0.00%> (-0.02%) |
:arrow_down: |
python-package/securexgboost/core.py | 38.72% <0.00%> (-0.99%) |
:arrow_down: |
core.py
inAPI_BEGIN()
andAPI_END()
calls to ensure smooth error handling. Previously, errors were either printed to console and not returned to Python or were thrown usingLOG(FATAL)
which would kill the process ungracefully.