search

mc706 / changelog-cli

A Command Line Interface that makes it easy to manage a helpful Changelog
MIT License
17 stars 15 forks source link

Modernization and typing #21

Closed movermeyer closed 3 years ago

movermeyer commented 3 years ago

Now that we've dropped Python 2.7, it's time to modernize the codebase.

You can review commit by commit for easier reading.

Merge after #20

mc706 commented 3 years ago

Also curious on thoughts of using a more modern type checker than mypy. In other environments we have run into mypy choking on the walrus operator and any of the new dictionary operators so we have moved to pyre and have found other nice side benefits (speed). I dont have strong opinions here since I dont see us using the walrus operator or any of the newer things while 3.6 is still supported and the codebase isnt large enough to justify speed as a reason to move.

movermeyer commented 3 years ago

@mc706

Also curious on thoughts of using a more modern type checker than mypy.

Happy to use whatever. I've been working mostly in Ruby for the past 2 years, so I haven't had my finger on the pulse of the Python community. If pyre is better, let's use it. 👍

My only initial hesitation with pyre is its lack of Windows support. But it does seem to work under WSL, so it shouldn't be a blocker.

I've dropped the CI changes from this PR anyway. I'll add it in (and other linters) when I do #25.