mcMMO-Dev / mcMMO-Classic

mcMMO Classic.
https://www.spigotmc.org/resources/official-mcmmo-classic.2445/
Other
37 stars 44 forks source link

Mining double drops broken. #21

Closed selfslaughter closed 5 years ago

selfslaughter commented 5 years ago

Mining double drops appear to be broken on 1.6.1-Snapshot builds. Everything works fine on the last stable release 1.6.0.

Re-tested today with the latest build (commit b483602) on a fresh 1.13.2 test server running paper v621.

Additionally, commit f0ebff4 appears to of changed the config section from "Double_Drops" to "Bonus_Drops" without changing the default config file.

Renaming the Double_Drops section to Bonus_Drops in the cfg, Which although it additionally re-creates the Double_Drops section appears to work for fixing herbalism/woodcutting double drops, But not for mining.

Thanks and Happy Easter. :)

nossr50 commented 5 years ago

Thanks I'll look into this soon.

selfslaughter commented 5 years ago

Thanks, I see whats going on with mining now. It's only giving double drops with a silk touch pick.

With a normal pick you no longer get any extra drops.

nossr50 commented 5 years ago

Remove the bonus drops section from your config and test again

selfslaughter commented 5 years ago

Just tested again on a completely fresh test setup and same thing.

Mined 9 ore with a normal pick and got 9 diamond. Mined 9 ore with a silk pick and got 27 diamond ore.

Untitled

nossr50 commented 5 years ago

@selfslaughter Okay I'll start up classic on my test server and see if I can reproduce.

selfslaughter commented 5 years ago

No need to rush, enjoy the holiday break. :)

nossr50 commented 5 years ago

@selfslaughter Yeah its a bit odd this is only happening in classic, testing to see if I can reproduce now.

nossr50 commented 5 years ago

Well its fixed now, delete your config.yml to regen or update its Bonus_Drops section manually

selfslaughter commented 5 years ago

Yeap, all good now. Thanks for your continued efforts on this. Looking forward to seeing how 3.0 shapes up. :)