search

mcMMO-Dev / mcMMO-Classic

mcMMO Classic.
https://www.spigotmc.org/resources/official-mcmmo-classic.2445/
Other
37 stars 44 forks source link

Hang while enabling mcMMO Classic 1.6.5 #90

Open SXRWahrheit opened 2 years ago

SXRWahrheit commented 2 years ago

This is a new one for me. It loads fine on my remote server, but locally on Windows 11 with Java 17 it seems like there's a hang with no response. The process is still running, it's just nothing else happens server-side. Log file here:

https://paste.denizenscript.com/View/92458

SXRWahrheit commented 2 years ago

It actually did end up loading after an extraordinarily long time. Whatever is being loaded, can it not be moved to sometime after the enable event?

[21:12:52] [Server thread/INFO]: [mcMMO] Enabling mcMMO v1.6.5
[21:18:16] [Server thread/INFO]: [Vault] Enabling Vault v1.7.3-b131
Diablolend commented 2 years ago

This problem also occurred to me. I turned on debug-mode and found out that the reason for this is an overflowing experience.yml file. It began to take up more than 700 MB.

SXRWahrheit commented 2 years ago

Apparently this bug was fixed in the new version of mcMMO but the fix has not been applied to classic. It'd be nice to see this fixed.

I also confirmed it was the experience.yml comment issue myself and forgot to report it earlier - I'm glad someone else did, too.

SXRWahrheit commented 2 years ago

This issue persists and could be fixed simply. Please address it for those of us who still use Classic.

Chew commented 2 years ago

If it can be fixed simply, you are more than welcome to open a PR and we'll be happy to review it :)