Super Breaker + protected ore blocks = free diamonds and mcmmo skill.

VergilPrime commented 12 years ago

Changelog says fixed, but its not :(

HosfordDotMe commented 12 years ago

I can also verify that this is not fixed.

t00thpick1 commented 12 years ago

Can also verify. But also offer that in your excavation gigabreaker check shouldn't be:
if (!mcMMO.placeStore.isTrue(block) || !Misc.blockBreakSimulate(block, player, true)) {

but instead if (!mcMMO.placeStore.isTrue(block) && !Misc.blockBreakSimulate(block, player, true)) {

Because at the moment it runs if either is false. when it should only run when both are false...

t00thpick1 commented 12 years ago

Also in your superbreaker check you put Misc.blockBreakSimulate(block, player, true) under if (ModChecks.isCustomMiningBlock(block)) {

It should also be under the else statement for that otherwise it only runs on custom blocks....

t00thpick1 commented 12 years ago

https://github.com/mcMMO-Dev/mcMMO/pull/232

t00thpick1 commented 12 years ago

This is fixed now

kentfredric commented 12 years ago

Recently have encountered a variant of this bug in 1.3.11-b1030

It requires a clicker macro to really utilize.

Protect natural ores with GriefProtection ( http://dev.bukkit.org/server-mods/grief-prevention/ )
Use a fast-click macro in conjunction with SuperBreaker.

Its not enough to just try mining with SuperBreaker, very fast clicking must be done to really get the best out of it, and when you get macro-speed fast-clicking, the ores will spew diamonds, ( and spew more diamonds with fortune, and spew ores with silk touch ).

And by "Spew diamonds" I mean, "You'll have a whole stack in the 4 seconds you get to mine with superbreaker"

It /feels/ like a sort of "race condition" bug, but I don't know the code well enough to say for sure.

Glitchfinder commented 11 years ago

I am closing this issue since it has long since been resolved.

mcMMO-Dev / mcMMO

Super Breaker + protected ore blocks = free diamonds and mcmmo skill. #231