mcMMO-Dev / mcMMO

The RPG Lover's Mod!
https://mcmmo.org
GNU General Public License v3.0
1.01k stars 864 forks source link

[Bug] "Call of the Wild" Summoned animal stays forever #3770

Open MrSpock78 opened 5 years ago

MrSpock78 commented 5 years ago

Summoned animals sometimes will not despawn even with despawn-timer set. How to reproduce: Summon an animal, tp away, wait until the chunk is unloaded and tp back.

nossr50 commented 5 years ago

While this is an interesting exploit I almost wonder if we care if the summoned animals stay forever, in fact, why do they have a time limit? 🤔

TheBentoBox commented 5 years ago

Something else to note with this is that you can summon two animals and breed them, and then the baby is permanent even if the parents properly despawn. If you end up trying to fix this instead of removing the time limit, you should try to fix that as well. The EntityBreedEvent is cancellable so you should be able to cancel it if either the mother or father are an mcMMO-summoned entity. But I do agree that you could probably just remove the time limit (and maybe increase the base cost to compensate, or add an additional cost to it).

nossr50 commented 5 years ago

@TheBentoBox I had no idea we were allowing summoned animals to breed, that's def a no-no imo

mrfloris commented 5 years ago

*

While this is an interesting exploit I almost wonder if we care if the summoned animals stay forever, in fact, why do they have a time limit? 🤔

So either have no limit at all, or properly deal with limits and un-chunk-ables :)