mcMMO-Dev / mcMMO

The RPG Lover's Mod!
https://mcmmo.org
GNU General Public License v3.0
998 stars 864 forks source link

[Suggestion] Spear fishing perk unlocked #3888

Open mrfloris opened 5 years ago

mrfloris commented 5 years ago

At a certain high level, it would be nice if we could use our trident (the one with the enchant where it comes back to you) to do some spear fishing on 'real' fish in the water. At an even higher level it could also allow you to spear fish dolphins and squid maybe, and include treasure like shell for dolphin and extra ink for squid, or whatever might be reasonable.

nossr50 commented 5 years ago

Potentially checks like this can be expensive, but they'd only happen while Tridents were travelling. I could also raytrace the path and see if it would hit anything to reduce the calculations. Hitscan style. It's something to consider.

mrfloris commented 5 years ago

Doesn't it only need to check when the event of the fish being killed by it is done by player x, and return fish to the inventory?

nossr50 commented 5 years ago

My bad I was overthinking it!

I didn't realize the fish could die, I thought they were decorations

mrfloris commented 5 years ago

People can grind fishing in 1.13 with soul sand and catch fish at surface, and auto collect their drops when they die from suffocation etc. a guardian grinder can be in 1 chunk and almost as effective as well. It's kinda crazy in 1.13

yeh, defn. worth playing a bit of vanilla mc to see what's up

mrfloris commented 4 years ago

Friendly bump, we're on 1.15.2 now with mcmmo 2.1, i tried checking the wiki for info about tridents but didnt' see much. Is there spear fishing in 2.1 or planned for 2.5 or something? When mobs get killed with trident does it go towards a certain skill?

nossr50 commented 4 years ago

This is a clever idea, I'll see if or when I can add this.