Fishing in a minecart propels you through the air

mcMMO-Dev / mcMMO

The RPG Lover's Mod!

https://mcmmo.org

GNU General Public License v3.0

1k stars 863 forks source link

Fishing in a minecart propels you through the air #4010

Open Seeroh opened 5 years ago

Seeroh commented 5 years ago

Steps to reproduce:

1. Place down rails, then minecart
2. Destroy rails, then hop into minecart
3. Ensure you are in survival mode, and then cast your line (preferably UP for best results)
4. Die from fall damage

I tested this on 2.1.99 after @MattTek#7997 pointed it out on Discord. This behavior does not occur without mcMMO installed. I also removed all plugins but CMI, Vault, Luckperms, and mcMMO, and still had the same results.

2019-08-01_18 56 52 2019-08-01_18 56 55 2019-08-01_18 56 57

BillyGalbreath commented 5 years ago

Can confirm.

Player reported it to me, can easily reproduce in survival mode.

https://youtu.be/5VVV9IScOFU <- with McMMO installed.

https://youtu.be/ptYvzQ4_4qI <- without McMMO installed.

electronicboy commented 5 years ago

Two things: 1) This is intentional o.O 2) It wasn't checking the configuration for fishing exploits

Fixed 2, should prooobably revisit 1, however

spencerbass commented 4 years ago

Found the problem here: https://github.com/mcMMO-Dev/mcMMO/blob/296d8ee7c106c31c72fddc4f830c3fad4fa0fba6/src/main/java/com/gmail/nossr50/listeners/PlayerListener.java#L754