search

mcMMO-Dev / mcMMO

The RPG Lover's Mod!
https://mcmmo.org
GNU General Public License v3.0
1.01k stars 865 forks source link

[BUG] Absorption and Bleeding #4458

Closed ghost closed 3 years ago

ghost commented 3 years ago

Sometimes bleeding set absorption to NaN, because of this, the player became immortal

nossr50 commented 3 years ago

Do you have an error log?

ghost commented 3 years ago

No, it's does give an error, but i disabled the swords, axe and unarmed skills in PvP, and it solved the problem.

My server is running in 1.16.5

TheBusyBiscuit commented 3 years ago

Could you please re-enable them and post the error via https://www.pastebin.com (or a similar pasting site), then someone can look into it and see if they are able to fix it.

samukatb commented 3 years ago

I have the same problem, i tried disabling swords in pvp and the problem is solved. I'm using 1.16 with DeluxeCombat to have 1.8 pvp. And when the player became immortal, it gives this error https://pastebin.com/01Mu1QjM When i disable swords, a left the server running for 1 week and it solved the bug.

TheBusyBiscuit commented 3 years ago

@samukatb That error is from DeluxeCombat though, so you may want to report it to them.

samukatb commented 3 years ago

@samukatb That error is from DeluxeCombat though, so you may want to report it to them.

Player still became immortal withotu deluxe. But without deluxe, it does not give any error in console. It can be a problem when using old pvp, because i have the same problem when i use OldCombatMechanics to have old pvp from 1.8

TheBusyBiscuit commented 3 years ago

You may still want to report the error to them though nonetheless, so they are able to look into that and fix it. But that may just be completely unrelated to the issue here, still worth to always report errors when you find them though!

timderspieler commented 3 years ago

Hello, timderspieler here (the author of DeluxeCombat),

the given error happens when null or NaN gets passed to my double function. @TheBusyBiscuit DeluxeCombat gets his damage by the EntityDamageByEntity event, I guess you set it to NaN or just null. Can you please check that? I just can implement a null check, but I dont think that fixes the main issue.

greetings

ghost commented 3 years ago

@nossr50 any news about this bug? I got to the point of having to disable McMMO to prevent the problem.

nossr50 commented 3 years ago

Rupture was rewritten so I’d be surprised if you still had this issue

ghost commented 3 years ago

Well, I was using version 2.1.188 when I still had a problem with immortality .. I deactivated the main skills that directly influence PvP, and I had no more problems, as I said earlier .. It was only when I activated it again that the bug happened again.. Sometimes I noticed an immortal player due to DC errors on the console, when the server dropped TPS. I am not sure how to replicate the bug, but it is solved when I disable pvp skills. Swords, axe and unarmed

nossr50 commented 3 years ago

Still don’t understand how the error is on our side, we aren’t doing anything odd or unusual and every other plugin works fine with us

timderspieler commented 3 years ago

@nossr50 as I said @LtSam notices the issue by the errors DeluxeCombat is posting into the console. The NaN exception appears when the damage from the EntityDamageByEntity event is set to null.

I can add a NaN check which does not fix the issue on your side.

greetings

ghost commented 3 years ago

@nossr50

Any predictions to fix the immortality bug? I'm still having the problem

ghost commented 3 years ago

@nossr50 I'm still having the problem

rodrigoveglo commented 2 years ago

I know that this case was already closed, but I have the solution to the problem in case someone has the same problem, the only thing you have to do is to run this command /attribute {player} minecraft:generic.max_health base set 20 this will force the user to have 20 health and will not bug him, remember that when running this command the bugee user must remove his armor if he adds extra hearts.