search

mcMMO-Dev / mcMMO

The RPG Lover's Mod!
https://mcmmo.org
GNU General Public License v3.0
1k stars 862 forks source link

furnace bug 1.17.1 #4583

Closed popcorn9499 closed 2 years ago

popcorn9499 commented 3 years ago

So when I went to open a new furnace with mcmmo on minecraft 1.17.1 I would try to put an item into the inventory and it would kick me out of the inventory and if I shift clicked the item that item would be missing from my inventory never to be seen again. It would also not be in the furnace I placed it in. However after this initial bug you will never see it again on the same furnace. a video of the bug

/version: This server is running CraftBukkit version 3202-Spigot-18c71bf-64d149a (MC: 1.17.1) (Implementing API version 1.17.1-R0.1-SNAPSHOT)

running the latest mcmmo built from the master repo.

This issue does not appear on spigot 1.17 only 1.17.1

popcorn9499 commented 3 years ago

I apologize I realize I forgot to send a copy of the server log so here it is

gecko10000 commented 3 years ago

Seems like the issue stems from this commit, specifically the last CraftBukkit change to "properly clear tile entities before replacing."

popcorn9499 commented 3 years ago

ah that makes alot of sense actually. doesn't make it any less annoying but its cool to understand what's going on.

codebycam commented 3 years ago

This doesn't happen on the latest Paper/Tuinity, however I was facing this issue with mcMMO whilst running a specific version of Tuinity:

[02:02:06 INFO]: This server is running Tuinity version git-Tuinity-25 (MC: 1.17.1) (Implementing API version 1.17.1-R0.1-SNAPSHOT) (Git: de19b33 on HEAD)
Unknown version
Previous version: git-Tuinity-26 (MC: 1.17.1)
[02:02:21 INFO]: mcMMO version 2.1.200
gecko10000 commented 3 years ago

Yep, the bug should be fixed on Spigot and all forks that have pulled from Spigot within the past 15 hours or so (Paper, Tuinity, Purpur, etc.)

NightLife-SG commented 3 years ago

Im having the issue tho,running paper 1.17.1 build 127

When shift clicking into furnace the item just gone. But this bug appear when you place down a new furnace and try to put item in it. This issue wont be appearing if the furnace has been registered.

popcorn9499 commented 3 years ago

Thank you. Hadn't realized that one of the builds from today fixed it. Sorry that I made a bug report for not really a mcmmo bug

NightLife-SG commented 3 years ago

still,having the issue using latest build on paper 130 #1.17.1

gecko10000 commented 3 years ago

Yep, I tested it with Spigot, Paper, Tuinity, and Purpur last night and they all worked... except Paper. Paper asked me to open a bug report describing replication details but I personally am not sure of the code that causes this to happen. For the time being, you can switch to one of the other forks (Tuinity has better performance anyways) to fix your issues.

nossr50 commented 3 years ago

For now you can use Spigot until Paper patches this issue

mrfloris commented 3 years ago

Using paper for a few days now and can't reproduce this. they upstream patch. Update your spigot/paper and this goes away.

popcorn9499 commented 2 years ago

since I imagine this issue was fixed long ago and according to the latest comment it was patched upstream so I will mark this as closed