search

mcMMO-Dev / mcMMO

The RPG Lover's Mod!
https://mcmmo.org
GNU General Public License v3.0
988 stars 855 forks source link

McMMO rewards/treasures unable to be used in various ways. #5041

Open GoodrichDev opened 2 weeks ago

GoodrichDev commented 2 weeks ago

I am on 2.2.013, I have reviewed the commits for 2.2.014 and 2.2.015 and they do not seem to touch the issue.

It seems that Mojang no longer represents itemStacks as raw NBT anymore when they are loaded, they now use data components. It seems like this plugin is trying to do manual NBT changes which will no longer work.

This has caused a bunch of weird scenarios in which items obtained from fishing are unable to benefit from Mending, they can't be repaired in an anvil and can't be put through a grindstone.

Our server is using the following:

This server is running Folia version 1.20.6-5-master@d797082 (2024-06-19T22:19:29Z) (Implementing API version 1.20.6-R0.1-SNAPSHOT)
You are running the latest version

However, I have tested this on 1.20.6 Paper and had the same issues.

nossr50 commented 2 weeks ago

mcMMO doesn't edit any NBT directly, only through Spigot API Regardless, this is a strange issue, I will look into it

GoodrichDev commented 2 weeks ago

mcMMO doesn't edit any NBT directly, only through Spigot API Regardless, this is a strange issue, I will look into it

Thank you, feel free to add me on Discord or ping me in your Discord Server, @georgeorwells1984. Happy to help!