mcMMO-Dev / mcMMO

The RPG Lover's Mod!
https://mcmmo.org
GNU General Public License v3.0
1.01k stars 867 forks source link

Fix slime spawner exploit #5089

Closed Ineusia closed 1 month ago

Ineusia commented 2 months ago

Currently, slime/magma cube meta gets cleaned at death which fires before the Transform event. This means the smaller slimes/magma cubes from a spawner slime will not have tags carry over, allowing players to farm combat skills from spawned mobs.

This PR moves cleaning for Slimes/Magma Cubes to after the transform event, which we know means the slime is dead anyways, so it's fine to clean them there.