mcMMO-Dev / mcMMO

The RPG Lover's Mod!
https://mcmmo.org
GNU General Public License v3.0
988 stars 855 forks source link

Negated permissions (parent) not negating children perms #751

Closed FuRiouSOne closed 11 years ago

FuRiouSOne commented 11 years ago

I have -mcmmo.abilities.all in permissions but players still have all abilities which they shouldn't.

I have my server set up to give specific abilities to specific groups and was working pre 1726 build. After updating to 1726 all groups now have superbreaker, serrated strikes and gigadrill which they shouldn't.

Example: This worked pre 1726 permissions: **_NEGATED_*

gmcferrin commented 11 years ago

@FuRiouSOne What build were you using prior, so I can check the changes?

FuRiouSOne commented 11 years ago

version: 1.4.00-dev2-b1438

FuRiouSOne commented 11 years ago

Also using groupmanager if that helps. version: 2.0 (2.9.6) (Phoenix)

FuRiouSOne commented 11 years ago

Went and added in

And now is working but shouldnt - -mcmmo.ability.all work too? Something got goofed with child perms somewhere. Basically i run a prison server and do not want players to have superbreak or giga, and ONLY guard to have counterstrike and serratedstrike so i negate ALL abilities to everyone and add in only what they should have by using - -mcmmo.ability.all and adding in - mcmmo.ability.swords.bleed for everyone and giving guards serratedstrike and counterattack but this update ended up giving everyone all abilities in the skill if they had just one permission node within the ability parent.

Hope that explains it better. Either way i think i have fixed it on my end reworking the permissions a bit different but should still be looked into.

FuRiouSOne commented 11 years ago

This can be duped to Issue #753 or vice versa as im sure its the same issue.

Glitchfinder commented 11 years ago

All right, so I think I know part of why this isn't working properly. Would you be willing to test something for me and attempt to deny the permission mcmmo.defaults? That should work, even if the other permissions didn't.

FuRiouSOne commented 11 years ago

Sure when we figure out whats causing players to stop earning xp at random. Going to be hard to test this if players arnt earning xp (could be confused with them not having said permissions).

gmcferrin commented 11 years ago

@FuRiouSOne Would you please try out the latest dev build (#1733)? I think I may have found the problem, or at least a problem.

FuRiouSOne commented 11 years ago

Applied, awaiting feedback from players.

TfT-02 commented 11 years ago

So? Did that fix this issue?

FuRiouSOne commented 11 years ago

@TfT-02 Im really not sure about the parent child permissions as i have just did away with limiting groups getting certain mcMMO skills/abilites and give everyone (with build rights) all default mcMMO skills/abilites as it should be.

1755 build has fixed many major issues we were all having from the first RC build of mcMMO yes. I have yet to see any issues reported by my player base since updating to 1755 so i would say close this ticket. Thank you.

TfT-02 commented 11 years ago

Alright, closing this ticket now. If this issue arises again, please reopen this ticket instead of submitting a new one. ;)