Closed rofinn closed 2 years ago
Nightly failure seems to be pre-existing.
Hmm, it seems like this is only faster in some cases so far. I wonder if the performance of this function is somehow related to the relative sizes of the dimensions?
Closing in favour of #126 which reduces the allocations by another order of magnitude and is faster in all cases I tried.
Rewrites
populate!
to operate columnwise over tables. Also, requires manually callingfindall
with the axiskeys and columns. With these changes thewrapdims
call is ~5x faster and allocations 25% of the memory.Old:
New: