search

mcabbott / AxisKeys.jl

🎹
MIT License
149 stars 28 forks source link

turn most deps into weakdeps #151

Closed aplavin closed 8 months ago

aplavin commented 8 months ago

Closes https://github.com/mcabbott/AxisKeys.jl/issues/150. I got so used to AxisKeys bringing lots of these packages as dependencies, didn't even think that with 1.9 they can be made optional :) Only noticed after seeing the recent issue opened here.

Tests (should) pass on both 1.6 and 1.9. Failures on 1.10 unrelated: there's a known Julia issue with new ambiguities https://github.com/JuliaLang/julia/issues/52386 https://github.com/JuliaLang/julia/issues/52263 https://github.com/JuliaSparse/SparseArrays.jl/issues/431.

mcabbott commented 8 months ago

Awesome, thanks!

Do you know whether names like StatisticsExt can or cannot cause problems by being used elsewhere? Many packages shove their own name into the ext name.

aplavin commented 8 months ago

There was a short period of time around 1.9 release, when some tools like PackageCompiler didn't work with duplicated extensions names. Somehow, this situation ended up so ingrained... See https://github.com/JuliaLang/Pkg.jl/pull/3600#issuecomment-1692809147 thread on giving more specific naming recommendations in Pkg docs. Now, there are no known problems with extension names.