search

mcabbott / SliceMap.jl

Same-same but different
Other
31 stars 3 forks source link

Attempt to make compatible with Julia nightly #15

Closed pat-alt closed 2 years ago

pat-alt commented 2 years ago

Hi there,

thanks for this great package. I've added it as a dependency for CounterfactualExplanations.jl and it saved me a lot of pain the other day 😆. I noticed that the nightly version no longer passes tests though - see the issue in my own package CI here and related warning here.

After replacing all Slices by JuliennedArrays.Slices the CI for nightly now passed without errors on my fork, but an error that I don't understand came up for Julia 1.3. Contributing this anyway in the hope that perhaps you know what to do.

Thanks!

mcabbott commented 2 years ago

Great, thanks for having a look.

Can you try deleting the manifest here? I think this should not be checked in. And it might be that this is what's causing the failure on 1.3.

If that doesn't work, simply dropping Julia 1.3 is totally fine, it's ancient history.

pat-alt commented 2 years ago

Have moved to 1.7 and also bumped up the package version 👍🏽

mcabbott commented 2 years ago

Thanks!