Make lib/plugin folder in Makefile if it doesn't exist

mcaceresb / stata-parquet

Read and write parquet files from Stata

MIT License

22 stars 6 forks source link

Make lib/plugin folder in Makefile if it doesn't exist #15

Closed kylebarron closed 5 years ago

kylebarron commented 5 years ago

When trying to install manually without using conda the lib/plugin folder doesn't already exist.

mcaceresb commented 5 years ago

Why delete lib/plugin/parquet_unix.plugin? I guess bc the user is always supposed to build it?

kylebarron commented 5 years ago

At this point 1) since we're depending on dynamic linking and 2) because Arrow/Parquet is most likely compiled differently on different linux platforms, I don't really see any benefit to including the compiled plugin

mcaceresb commented 5 years ago

Fair. It only gave me pause bc in other applications including the plugin is useful in some contexts, but I agree that in this case it doesn't make too much sense.