search

mcallegari / qlcplus

Q Light Controller Plus (QLC+) is a free and cross-platform software to control DMX or analog lighting systems like moving heads, dimmers, scanners etc. This project is a fork of the great QLC project written by Heikki Junnila that aims to continue the QLC development and to introduce new features.
Apache License 2.0
1.02k stars 360 forks source link

Button Icon should be next to text #1455

Open Loewe111 opened 1 year ago

Loewe111 commented 1 year ago

Describe the bug If you set an icon on a button its just applied like a background ( see first image) , it would make more sense to place it next to the text

current behavior:

To Reproduce Steps to reproduce the behavior:

  1. Go to 'Virtual Console'
  2. Create a button with text
  3. Set an icon (using the context menu)
  4. See error

Expected behavior The icon should be placed next to the text (preferably on the left) like in the second image

Screenshots current image 1

expected image 2

Desktop (please complete the following information):

mcallegari commented 1 year ago

This is as designed: a text with a background image. QLC+ doesn't know you're setting an icon and doesn't know you want it aligned on the right (what if someone wants it to be aligned on the left? top-left? bottom-left? bottom-right? etc..) I suggest to create background images as you prefer and apply only that

Loewe111 commented 1 year ago

When i right click on a button i have two options, background and symbol grafik

It seems like they aren't the same thing, because if i set a symbol i am able to select svg, which i am not able to do with a background. They also have different shortcuts, so I assumed they are two different things.

Edit: Screenshot with language set to english grafik

mcallegari commented 1 year ago

OK, I checked and you're right. I totally forgot about that feature! Drawing the icon beside text is not feasible. Text is center aligned and wrapping words. I propose to draw a custom icon on the top left corner of the button. In this way you can have flashing icon (top right) + custom icon (top left) Sounds good?

Loewe111 commented 1 year ago

Thats a sounds good, i assume the image would be scaled to a fixed size, right?

mcallegari commented 1 year ago

That's the idea but I'm still thinking about it. I believe such change can break existing consoles like this, where they use gobos as icons

Screenshot_20230911_124143

Loewe111 commented 1 year ago

Im not sure if that would be possible to implement, but maybe converting the icons to background images with the new version could work

(i dont know if the qlc+ version is stored in the project file) meaning if the version is less than version ... just convert them i havent really looked at the source code, so i dont know how and wheter that can be implemented