mcallegari / qlcplus

Q Light Controller Plus (QLC+) is a free and cross-platform software to control DMX or analog lighting systems like moving heads, dimmers, scanners etc. This project is a fork of the great QLC project written by Heikki Junnila that aims to continue the QLC development and to introduce new features.
Apache License 2.0
991 stars 356 forks source link

Webaccess cuelist side fader #1477

Closed Itay-Lifshitz closed 11 months ago

Itay-Lifshitz commented 11 months ago

Hi, @mcallegari Cue List side fader(none, crossfade, steps) is now supported Please review it and give me feedbacks.

coveralls commented 11 months ago

Coverage Status

coverage: 28.086% (+0.02%) from 28.067% when pulling 0dcaad7bd1fd81f85b4d89f2910dee527de682f6 on Itay-Lifshitz:webaccess_cuelist_sliders into d187efff67b8d95c0199ea3a93ca8ac2cec59f2c on mcallegari:master.

mcallegari commented 11 months ago

@Itay-Lifshitz ok, almost there. It works well except for the label colors. If you look at the original widget in the virtual console, you will notice that during playback, steps (and side fader labels) are colored in orange and blue, to indicate the current step and the next step. Please check if this is feasible too on web interface, otherwise for now let's proceed with this. I haven't done a code review yet. First I wanted to check if it was working as expected. Thanks

Itay-Lifshitz commented 11 months ago

@Itay-Lifshitz ok, almost there. It works well except for the label colors. If you look at the original widget in the virtual console, you will notice that during playback, steps (and side fader labels) are colored in orange and blue, to indicate the current step and the next step. Please check if this is feasible too on web interface, otherwise for now let's proceed with this. I haven't done a code review yet. First I wanted to check if it was working as expected. Thanks

OK. I will update the label colors.

mcallegari commented 11 months ago

@Itay-Lifshitz a few things to rename (see my comments) but the rest works pretty well. Thanks

Itay-Lifshitz commented 11 months ago

@Itay-Lifshitz a few things to rename (see my comments) but the rest works pretty well. Thanks

I have fixed. Please check again.

mcallegari commented 11 months ago

Thanks 👍