Webaccess frame enable disable v2

mcallegari / qlcplus

Q Light Controller Plus (QLC+) is a free and cross-platform software to control DMX or analog lighting systems like moving heads, dimmers, scanners etc. This project is a fork of the great QLC project written by Heikki Junnila that aims to continue the QLC development and to introduce new features.

Apache License 2.0

991 stars 356 forks source link

Webaccess frame enable disable v2 #1485

Closed Itay-Lifshitz closed 8 months ago

Itay-Lifshitz commented 10 months ago

@mcallegari Hi, the following widgets' enable/disable states are changed when you check/uncheck the frame enable.

VCButton VCSlider VCKnob VCCueList VCLabel VCClock Please review and give feedback.

Thank you.

coveralls commented 10 months ago

coverage: 32.011% (-0.001%) from 32.012% when pulling abfb6eaadf254208a0ba42939526fe78f1aee12d on Itay-Lifshitz:webaccess_frame_enable_disable_v2 into a3b44ae9df27b2c682cd9a9d2411ba610d648d07 on mcallegari:master.

Itay-Lifshitz commented 9 months ago

@mcallegari Can you please let me know the status of this PR? What is preventing you from reviewing/closing this PR?

mcallegari commented 9 months ago

@Itay-Lifshitz I'm working on some other tasks at the moment. I'll review this when I'm done

yestalgia commented 9 months ago

@Itay-Lifshitz there's a few quick styling changes which would be appreciated in the Codacy report.

https://app.codacy.com/gh/mcallegari/qlcplus/pullRequest?prid=13065141

Should only take a few mins to resolve. Happy to collab if you give me access to the branch.

mcallegari commented 8 months ago

@Itay-Lifshitz merged, thanks :+1: