search

mcallegari / qlcplus

Q Light Controller Plus (QLC+) is a free and cross-platform software to control DMX or analog lighting systems like moving heads, dimmers, scanners etc. This project is a fork of the great QLC project written by Heikki Junnila that aims to continue the QLC development and to introduce new features.
Apache License 2.0
991 stars 356 forks source link

QLC+ 5: Add linear regression to BPM tapping #1503

Closed Wazzledi closed 8 months ago

Wazzledi commented 8 months ago

As described in forum thread https://www.qlcplus.org/forum/viewtopic.php?p=71374, I added the linear regression method used in QLC+ 4 to the BPM tapping functionality of QLC+ 5.

coveralls commented 8 months ago

Coverage Status

coverage: 32.012%. remained the same when pulling 99e7437faa843939e7dcddd0dbdda2aa706f583a on Wazzledi:master into a3b44ae9df27b2c682cd9a9d2411ba610d648d07 on mcallegari:master.

mcallegari commented 8 months ago

Hey, how about the Time edit tool too? https://github.com/mcallegari/qlcplus/blob/master/qmlui/qml/TimeEditTool.qml

There's another time tapping

Wazzledi commented 8 months ago

I totally forgot about this thing. For that, I moved the algorithm in the TimeUtil.js and added it to the TimeEditTool. While testing the TimeEditTool, I noticed that the Tap button is also shown when the chaser is set to beat. Is that intended? Also, I dont see x/2 and 2x anymore to get half beat chasers.

mcallegari commented 8 months ago

For that, I moved the algorithm in the TimeUtil.js and added it to the TimeEditTool.

Excellent. I would have done the same!

While testing the TimeEditTool, I noticed that the Tap button is also shown when the chaser is set to beat. Is that intended?

Nope. It's actually not needed

Also, I dont see x/2 and 2x anymore to get half beat chasers.

I guess you mean like Speed Dial? TimeEditTool is not meant to be a replacement for Speed Dial

Wazzledi commented 8 months ago

I guess you mean like Speed Dial? TimeEditTool is not meant to be a replacement for Speed Dial

When editing the chaser step length with the TimeEditTool and the type is set to beat, I assumed the buttons x/2 and 2x, which are present in the code, should be visible. If they are not intended to be visible, then just ignore this comment.

mcallegari commented 8 months ago

They are visible on a Beat-based RGB Matrix

image

mcallegari commented 8 months ago

Many thanks for this :+1: