search

mcallegari / qlcplus

Q Light Controller Plus (QLC+) is a free and cross-platform software to control DMX or analog lighting systems like moving heads, dimmers, scanners etc. This project is a fork of the great QLC project written by Heikki Junnila that aims to continue the QLC development and to introduce new features.
Apache License 2.0
991 stars 356 forks source link

Save dialog geometry for all QLC+ dialogs #1505

Closed Timebutt closed 8 months ago

Timebutt commented 8 months ago

This PR stores geometry settings for all dialogs in QLC+ that did not yet have this feature implemented. Some of the dialogs already had this (AddFixture, ...) which is very convenient, but some of them did not which can be incredibly frustrating when working on a 4K monitor and having to repeat an action many times during programming, but always having to resize the tiny dialog before you can make any change.

This PR does not include the same functionality for QWidgets, I think I saw a few of those that also used the saveGeometry() logic but not entirely sure if they all need this as well. If you think so @mcallegari I'll gladly do a pass over those as well!

coveralls commented 8 months ago

Coverage Status

coverage: 31.964% (-0.05%) from 32.012% when pulling f5917744fe0280a7c54cb03864aad90cfaf7d2e2 on Timebutt:save-dialog-settings-for-all-qlc-dialogs into a3b44ae9df27b2c682cd9a9d2411ba610d648d07 on mcallegari:master.

yestalgia commented 8 months ago

Thanks this will be a massive quality of life improvement.

mcallegari commented 8 months ago

Very useful, thanks :+1: