Added web interface for cue list notes live editing.

mcallegari / qlcplus

Q Light Controller Plus (QLC+) is a free and cross-platform software to control DMX or analog lighting systems like moving heads, dimmers, scanners etc. This project is a fork of the great QLC project written by Heikki Junnila that aims to continue the QLC development and to introduce new features.

Apache License 2.0

921 stars 349 forks source link

Added web interface for cue list notes live editing. #1515

Closed Binary-Vanguard-12138 closed 4 months ago

Binary-Vanguard-12138 commented 5 months ago

Hi, @mcallegari I added this PR for web interface of cut list notes live editing. Please review it and give me feedback.

coveralls commented 5 months ago

coverage: 31.994% (+0.04%) from 31.958% when pulling 08e4a693e99b731f189a246d8326179f67eb22c4 on Binary-Vanguard-12138:cuelist_note_live_edit into 09bd20f746c9f23865e51cc1f1ee48f1b6b5ea42 on mcallegari:master.

mcallegari commented 5 months ago

I just checked this one. Notes editing is OK but selecting a step from web and hitting play starts from the first element instead of from the selected one. In the native interface this is working as expected. Not sure if this is because of the change discussed above or if it ever was like this but it needs to be fixed. Can you please check?

Binary-Vanguard-12138 commented 5 months ago

@mcallegari Hi, I reverted setCueIndex to enableCue. Please review it again.

mcallegari commented 4 months ago

Merged, thanks. Cue selection is still not OK but I'll fix it myself