search

mcallegari / qlcplus

Q Light Controller Plus (QLC+) is a free and cross-platform software to control DMX or analog lighting systems like moving heads, dimmers, scanners etc. This project is a fork of the great QLC project written by Heikki Junnila that aims to continue the QLC development and to introduce new features.
Apache License 2.0
921 stars 349 forks source link

Blackout behaviour: EFX movements disrupted #1523

Closed yestalgia closed 3 months ago

yestalgia commented 4 months ago

Describe the bug The change to the way Blackout works in QLC+ is a welcome one. However there's a bug when it comes to EFX values.

When running a show, the desired result of a blackout button is to only stop light from exiting the fixtures. However, when the blackout button is pressed it also temporarily disables EFX's 8-bit values. This results in the fixatures violently returning to their last set position.

To Reproduce Steps to reproduce the behavior:

I've created a test showfile with two universes to help reproduce this issue. The first universe contains the fixtures but the problem is observed in the second universe which is taking the output from the first. (This can also be tested with hardware.) NOTE: The DMX monitor shows what should be happening, not actually what QLC+ outputs.

  1. Open QLC+
  2. Open attached Show File
  3. Switch to Live Mode
  4. Activate the "Aura Base Position" scene from the Virtual console
  5. Activate the "New EFX 01" EFX from the Virtual Console
  6. NOTICE: the correct values in the simple desk for Universe 1
  7. NOTICE: the incorrect (stuck) values for Universe 2

Expected behavior We should see the output from QLC+ match the simple desk and DMX Monitor for Universe 1.

Screenshots If applicable, add screenshots to help explain your problem. image

Desktop (please complete the following information):

Additional context EFX Blackout Problem.zip

Video of Problem

yestalgia commented 4 months ago

I've created a YouTube video to show the problem. (Sorry about the quality it's downscaled from 4k) https://youtube.com/watch?v=fqy60yNIisY

mcallegari commented 3 months ago

Is this still verified with 4.13.0 or latest build?

yestalgia commented 3 months ago

Observation:

I did a new test which found a problem still exists. There was a slight change in the behaviour: Now all position channels for the fixtures "Pause" (They stop moving when blackout is active) not just the 8bit (fine) channels.

Test Methodology

Test conducted using Actions Build: https://github.com/mcallegari/qlcplus/actions/runs/8635670652

  1. Uninstall QLC+4 and QLC+5
  2. Download Actions Build - QLC+-qt5-4.13.1-20240410-d3cf816.exe
  3. Install as administrator
  4. Download EFX Blackout Problem.zip
  5. Extract EFX Blackout Problem and open the file from QLC+
  6. Activate the "Aura Base Position" scene from the Virtual console
  7. Activate the "New EFX 01" EFX from the Virtual Console