Fix fixture patch address verification

mcallegari / qlcplus

Q Light Controller Plus (QLC+) is a free and cross-platform software to control DMX or analog lighting systems like moving heads, dimmers, scanners etc. This project is a fork of the great QLC project written by Heikki Junnila that aims to continue the QLC development and to introduce new features.

Apache License 2.0

918 stars 349 forks source link

Fix fixture patch address verification #1543

Closed mxdumas closed 3 months ago

mxdumas commented 3 months ago

Fix for issue #1542 .

fxAddress is 0 based (0-511). If the requested address is 511 and the unit has 1 channel, it should fit. In this case, (fxAddress = 511) + (channels = 1) == (UNIVERSE_SIZE = 512) => Should be ok.

Simply need to remove the "=" to fix the issue.

Easy fix for a first timer! Was fun to figure my way around. ;)

coveralls commented 3 months ago

coverage: 32.084%. remained the same when pulling dda182a8b3788fc190ff90a0623e5cfec2900039 on mxdumas:master into 3b1999059b30b8801aa7f3587d415bce5766094b on mcallegari:master.

mcallegari commented 3 months ago

Nice catch, thanks :+1: