mcallegari / qlcplus

Q Light Controller Plus (QLC+) is a free and cross-platform software to control DMX or analog lighting systems like moving heads, dimmers, scanners etc. This project is a fork of the great QLC project written by Heikki Junnila that aims to continue the QLC development and to introduce new features.
Apache License 2.0
918 stars 349 forks source link

OSC error when an _ is present in the address #1547

Closed ghost closed 3 months ago

ghost commented 3 months ago

Describe the bug When a _ (underscore) symbol is present in OSC address, in QLC+ this happens:

To Reproduce In the OSC software, create a fader with "test_1" ID and associate it with a fader in QLC+.

  1. In the OSC software, move the created fader and check that QLC+ correctly interpreters the OSC message (in the console log of the OSC software, the OSC address generated is "test_1").
  2. In QLC+ move on the corresponding fader and verify that the fader in OSC software does not move (in the console log of the OSC software, the OSC address generated by QLC+ is "test").

Expected behavior QLC+ should generate the correct OSC address (in the example "test_1").

Screenshots None

Desktop (please complete the following information):

Additional context The same problem is also present in the 4.12.7 release.

mcallegari commented 3 months ago

Underscore is a reserved character used by QLC+ and cannot be used in paths

ghost commented 3 months ago

Thank you for feedback.