search

mcallegari / qlcplus

Q Light Controller Plus (QLC+) is a free and cross-platform software to control DMX or analog lighting systems like moving heads, dimmers, scanners etc. This project is a fork of the great QLC project written by Heikki Junnila that aims to continue the QLC development and to introduce new features.
Apache License 2.0
918 stars 349 forks source link

Use threading in VinceUSBDMX512 plugin and fix it #1556

Closed jeromelebleu closed 2 months ago

jeromelebleu commented 2 months ago

The VinceUSBDMX512 plugin is not working anymore in v4.13.0, the interface opening and closing are working but nothing is send to the output. I didn't spent too much time to try to understand why but instead I rewrite some part of it to use threading as the other dmxusb plugins. The output is now working again, there is still the input to code but I don't have required equipment to test.

Any review is welcome since I am not really familiar anymore with C++/Qt/FTDI… Thanks!

coveralls commented 2 months ago

Coverage Status

coverage: 32.074%. remained the same when pulling b5934595f0342db7f8bef599f13cbeadbde6840d on jeromelebleu:fix/vinceusbdmx512 into 77f12dc8ac505576445cb36cb4f8f48069a9a258 on mcallegari:master.

mcallegari commented 2 months ago

@jeromelebleu thanks for this :+1: Curious thing is that I can't really find anything about this interface by googling it! I wanted to purchase one to provide proper support...but it seems it doesn't exists! Looking at your changes I presume you have one and tested DMX output is working correctly now? Thanks

jeromelebleu commented 2 months ago

Unfortunately this interface is no longer available for sale, and the website is down for a while… Going back in time thanks to the Wayback Machine we can still have some information about it here but links to schematics and other files are down unfortunately - it was an open hardware.

I still have and using mine - and I'm maybe one of the last dinosaur who uses it especially with QLC+ - and the DMX output is working again with these changes.

mcallegari commented 2 months ago

Many thanks for the info! :+1: I'll merge it right away then, thanks