Fix bugs in Fixture Search

mcallegari / qlcplus

Q Light Controller Plus (QLC+) is a free and cross-platform software to control DMX or analog lighting systems like moving heads, dimmers, scanners etc. This project is a fork of the great QLC project written by Heikki Junnila that aims to continue the QLC development and to introduce new features.

Apache License 2.0

918 stars 349 forks source link

Fix bugs in Fixture Search #1560

Closed lilyCalla closed 1 month ago

lilyCalla commented 2 months ago

Bugs fixed:

selecting or deselecting a fixture with Fixture Groups panel open results in a segfault
Escape erases the names of fixtures and universes
Switching from Fixture Groups view to another view in the left panel and then switching back to fixture view does not clear filter until the search button is clicked again, without any visual indication that a filter is still active

coveralls commented 2 months ago

coverage: 32.068%. remained the same when pulling 6bf200f03c60652367971be5fb7fe9c63a7669af on lilyCalla:fixture-select-segfault into 3150b445eae811cd84ca76462ba33c98f1f6c074 on mcallegari:master.

lilyCalla commented 2 months ago

All stylistic issues resolved

mcallegari commented 2 months ago

I cannot reproduce the crash mentioned in the OP. Can you please explain exactly how to reproduce it?

lilyCalla commented 2 months ago

Ok sorry, forgot an important part of the crash.

Search for with a string that the filter you're about to click on does not match (such that it won't appear in the fixture group view). Then select it in the 2d view, and the application crashes

mcallegari commented 1 month ago

Thanks :+1: