QML version bumps - Githubissues

mcallegari / qlcplus

Q Light Controller Plus (QLC+) is a free and cross-platform software to control DMX or analog lighting systems like moving heads, dimmers, scanners etc. This project is a fork of the great QLC project written by Heikki Junnila that aims to continue the QLC development and to introduce new features.

Apache License 2.0

918 stars 349 forks source link

QML version bumps #1563

Closed mlowczynski closed 2 months ago

mcallegari commented 2 months ago

Hey @mlowczynski thanks for this I'm wondering if it makes sense to actually omit the version number so that the latest version is always imported: https://doc.qt.io/qt-6/qtqml-syntax-imports.html

coveralls commented 2 months ago

coverage: 32.068%. remained the same when pulling ba63e5435cf771eeb293dbdf9c070daa0fc96a97 on mlowczynski:qml-bumps into 3150b445eae811cd84ca76462ba33c98f1f6c074 on mcallegari:master.

mlowczynski commented 2 months ago

@mcallegari I have bumped QML module imports to the latest versions supported by Qt5 (5.15 LTS). This makes QML compatible with both Qt5 and Qt6. If the lack of compatibility with Qt5 is no longer a problem for us, it is better to use unqualified module import, as you suggested

mcallegari commented 2 months ago

@mlowczynski I just tested this. As you probably know, I work on Linux and the latest official 5.15 version is 5.15.2 which has an issue in Qt3D that prevents generic items to be loaded. This has been fixed in later commercial versions. So I tried with my Kubuntu Qt version (5.15.10) but I found so many issues there like misaligned buttons, 3D preview not working correctly, file dialogs not filtering files, etc. So the decision here is tricky. Since there will be effort in any case to fix a few UI things I'd say we can do this:

work on a branch: until this is completely fixed, it's better not to upstream this change as it breaks many things
use unqualified QML versions: at this point let's concentrate on Qt6 which will be the future default for a few years anyway

What do you think?

mlowczynski commented 2 months ago

I think this is a good approach. Do I understand correctly that we can close this PR for now?

mcallegari commented 2 months ago

Yeah, it's probably better to submit a new one. Sorry for the change of mind but this is a big change that needs careful attention.

mlowczynski commented 2 months ago

No problem