Refresh Cue List Widget on Addition or Removal of a Step from Chaser

mcallegari / qlcplus

Q Light Controller Plus (QLC+) is a free and cross-platform software to control DMX or analog lighting systems like moving heads, dimmers, scanners etc. This project is a fork of the great QLC project written by Heikki Junnila that aims to continue the QLC development and to introduce new features.

Apache License 2.0

918 stars 349 forks source link

Refresh Cue List Widget on Addition or Removal of a Step from Chaser #1564

Closed lilyCalla closed 1 month ago

lilyCalla commented 1 month ago

Currently adding or removing a widget is not reflected in the cue list widget unless the project is saved and reopened
Also apparent cause of crash at https://www.qlcplus.org/forum/viewtopic.php?t=17147, as the cue list would attempt to access a non-existent index
This PR reloads the chaser cue list if a function is added or removed from the linked chaser, allowing updates to be seen in real time and preventing the crash

coveralls commented 1 month ago

coverage: 32.014% (-0.05%) from 32.065% when pulling 9805f86cc6914dbdc339aea53e2dbdaa3c286a37 on lilyCalla:cuelist-refresh into 01fdda185ed1c008e0605669ec29dac4963511aa on mcallegari:master.

yestalgia commented 1 month ago

Love your work @lilyCalla

mcallegari commented 1 month ago

Looks good, thanks 👍

mcallegari commented 1 month ago

Actually, I overlooked these changes.

first signals should be using past form, so in chaser.h/cpp it's stepsListChanged, not stepListChange
also, a signal to update the UI was already present: https://github.com/mcallegari/qlcplus/blob/master/qmlui/virtualconsole/vccuelist.h#L198

I think the only change needed in vccuelist.cpp is this:

connect(function, SIGNAL(stepsListChanged(quint32)),
        this, SIGNAL(stepsListChanged()));

Please try that and re-submit a new PR. Thanks

mcallegari commented 1 month ago

Nevermind, I sorted this myself.