search

mcallegari / qlcplus

Q Light Controller Plus (QLC+) is a free and cross-platform software to control DMX or analog lighting systems like moving heads, dimmers, scanners etc. This project is a fork of the great QLC project written by Heikki Junnila that aims to continue the QLC development and to introduce new features.
Apache License 2.0
918 stars 349 forks source link

Add merger mode for HIDDMXDevices (DE/FX5/Nodle) #1567

Closed qfulmina closed 1 month ago

qfulmina commented 1 month ago

Adding the ability to set the DE/FX5/Nodle devices into merger mode as explained in the updated docs.

Tested with two Nodle R4S.

coveralls commented 1 month ago

Coverage Status

coverage: 32.007% (-0.007%) from 32.014% when pulling ba1929c17519d12c526d2c07d32a4d331c7a73eb on qfulmina:dev-add-hiddmx-merger-mode into ee16a5fe6af7383c48a49fc6d43e80adb0c23680 on mcallegari:master.

mcallegari commented 1 month ago

Hi, thanks for this. Preliminary comment before I make a full review of the code: documentation is no longer bundled with QLC+ and will eventually be removed from the repository too. So no need to update docs. Instead, please submit a pull request to the new in-sync documentation here https://github.com/mcallegari/qlcplus-docs that will be synced to https://docs.qlcplus.org/v4/plugins/hid

Thanks!

qfulmina commented 1 month ago

Sorry for committing uncleanly formatted code previously and thanks for the review, @mcallegari.

Should be fixed now. Will prepare a PR for the docs.

mcallegari commented 1 month ago

Merged, thanks a lot 👍

qfulmina commented 1 month ago

Thank you!